<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 5/30/2016 7:29 AM, Michail Chernov
wrote:<br>
</div>
<blockquote cite="mid:574C4E58.2030806@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Jon,<br>
<br>
We going to perform execution of G1 specific tests with
non-standard pauses. Typical log looks like:<br>
<br>
MaxGCPauseMillis (1000) must be less than GCPauseIntervalMillis
(50)<br>
GCPauseIntervalMillis (50) must be greater than MaxGCPauseMillis
(1000)<br>
Error: Could not create the Java Virtual Machine.<br>
Error: A fatal exception has occurred. Program will exit.<br>
<br>
All tests explicitly set MaxGCPauseMillis to some value, so if we
pass next option to VM ( -XX:MaxGCPauseMillis=30
-XX:GCPauseIntervalMillis=50) tests fail and VM gets the VM
options conflict.<br>
<br>
For example, test/gc/g1/ihop/TestIHOPErgo.java defines next
options during testing - -XX:MaxGCPauseMillis=30000, so
non-standard GC pauses causes to options range violation.<br>
<br>
This change excludes execution of tests if MaxGCPauseMillis is
defined.<br>
</blockquote>
<br>
Ok. I can see why you would not want MaxGCPauseMillis set by the
test.<br>
But it's Ok if the test sets GCPauseIntervalMillis?<br>
<br>
Jon<br>
<br>
<blockquote cite="mid:574C4E58.2030806@oracle.com" type="cite"> <br>
Thanks<br>
Michail<br>
<br>
<br>
<div class="moz-cite-prefix">On 27.05.2016 21:04, Jon Masamitsu
wrote:<br>
</div>
<blockquote
cite="mid:c3ca05e1-e135-4309-d5da-f23e49f5566e@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
From the bug report I would have thought you wanted to require
that<br>
GCPauseIntervalMillis not be set. How does this fix the
problem?<br>
<br>
<blockquote type="cite">
<pre><span class="new"> 31 * @requires vm.opt.MaxGCPauseMillis == "null"</span></pre>
</blockquote>
<br>
Jon<br>
<br>
<div class="moz-cite-prefix">On 5/27/2016 8:59 AM, Michail
Chernov wrote:<br>
</div>
<blockquote cite="mid:57486ED7.5020206@oracle.com" type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
Hi,<br>
<br>
Could I have a review for this small change which adds
necessary @requires tag to the tests, please?<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Emchernov/8157954/webrev.00/">http://cr.openjdk.java.net/~mchernov/8157954/webrev.00/</a><br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8157954">https://bugs.openjdk.java.net/browse/JDK-8157954</a><br>
<br>
This change is necessary for testing with defined
MaxGCPauseMillis.<br>
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<br>
Testing was performed.<br>
<br>
Thanks<br>
Michail<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>