<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi<br>
<br>
Added <a class="moz-txt-link-abbreviated" href="mailto:jtreg-use@openjdk.java.net">jtreg-use@openjdk.java.net</a><br>
<br>
I think that you are right. Here is the documentation:<br>
<a href="http://openjdk.java.net/jtreg/tag-spec.html">http://openjdk.java.net/jtreg/tag-spec.html</a><br>
<dl class="tags">
<dt><br>
</dt>
<dt>"@requires <var><expression></var></dt>
<dd>
<p>Express a dependence on characteristics of the system being
tested. Some harnesses allow tests to be selected according to
the
characteristics of the system being tested. The expression may
be
composed of the following elements:"</p>
</dd>
</dl>
"os.arch The operating system architecture, as given by the
corresponding system property."<br>
<br>
So user could expect to have "os.arch" of tested VM. <br>
<br>
If filed jtreg issues for this:
<ol class="aui-nav aui-nav-breadcrumbs __skate" style="margin: 0px;
list-style: none; padding: 0px;">
<li style="list-style: none; margin: 0px; padding: 0px 10px;
float: none; position: relative; display: inline;"><a
class="issue-link" data-issue-key="CODETOOLS-7901695"
href="https://bugs.openjdk.java.net/browse/CODETOOLS-7901695"
id="key-val" rel="4887212" style="color: rgb(59, 115, 175);
text-decoration: none;">CODETOOLS-7901695</a><span
style="color: rgb(51, 51, 51); font-family: sans-serif;
font-size: 24px; font-style: normal; font-variant: normal;
font-weight: normal; letter-spacing: normal; line-height:
30px; orphans: auto; text-align: left; text-indent: 0px;
text-transform: none; white-space: normal; widows: 1;
word-spacing: 0px; -webkit-text-stroke-width: 0px; display:
inline !important; float: none; background-color: rgb(245,
245, 245);"> <small><small>jtreg uses value 'os.arch'
property of JDK which executed JDK and not of tested JDK</small></small></span><br
class="Apple-interchange-newline">
</li>
</ol>
<br>
Following fix could be used as a temporary workaround while jtreg
fix is not ready. Does it make a sense? I this case it is needed to
change linux-arm64 back to linux-aarch64 to minimize changes.<br>
<br>
Leonid<br>
<br>
<div class="moz-cite-prefix">On 31.05.2016 04:26, David Holmes
wrote:<br>
</div>
<blockquote
cite="mid:a346027c-5f9b-4b82-b6f3-9b8657902759@oracle.com"
type="cite">Hi Leonid,
<br>
<br>
This really strikes me as as a jtreg problem that should be fixed
in jtreg. When writing an @requires clause in a test the test
writer should not have to be thinking "oh wait! Is this going to
query the VM running jtreg or the VM running the test?". It should
obviously be the VM running the test.
<br>
<br>
That said we also seem to have a problem with the definition of
os.arch:
<br>
<br>
os.arch Operating system architecture
<br>
<br>
if it is returning the build architecture of the VM and not the OS
it is running on. That in itself argues for two distinct
properties.
<br>
<br>
David
<br>
<br>
On 26/05/2016 11:45 PM, Leonid Mesnik wrote:
<br>
<blockquote type="cite">Hi
<br>
<br>
Could you please review following fix:
<br>
root <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~lmesnik/8157831/webrev.00/root/">http://cr.openjdk.java.net/~lmesnik/8157831/webrev.00/root/</a>
<br>
<a class="moz-txt-link-rfc2396E" href="http://cr.openjdk.java.net/%7Elmesnik/8157831/webrev.00/root/"><http://cr.openjdk.java.net/%7Elmesnik/8157831/webrev.00/root/></a>
<br>
hotspot
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~lmesnik/8157831/webrev.00/hotspot/">http://cr.openjdk.java.net/~lmesnik/8157831/webrev.00/hotspot/</a>
<br>
<a class="moz-txt-link-rfc2396E" href="http://cr.openjdk.java.net/%7Elmesnik/8157831/webrev.00/hotspot/"><http://cr.openjdk.java.net/%7Elmesnik/8157831/webrev.00/hotspot/></a>
<br>
for bug
<br>
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8157831">https://bugs.openjdk.java.net/browse/JDK-8157831</a>
<br>
<a class="moz-txt-link-rfc2396E" href="https://bugs.openjdk.java.net/browse/JDK-8157831"><https://bugs.openjdk.java.net/browse/JDK-8157831></a>
<br>
<br>
The property "os.name" which was used to filter tests depends on
the
<br>
arch of jdk which is used to run jtreg. It might differ from
arch of
<br>
tested jdk.
<br>
This fix introduce new property "vm.arch" which depends on the
arch of
<br>
tested jdk and could be used to filter tests with @requires.
<br>
<br>
I verified that tests are filtered where it is expected.
<br>
Note: I am going to push this fix in jdk9/hs to fix regular
hotspot
<br>
testing.
<br>
<br>
Leonid
<br>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>