<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Leonid,<br>
<br>
On 2016-06-09 14:30, Leonid Mesnik wrote:<br>
<blockquote cite="mid:57596179.5070407@oracle.com" type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi<br>
<br>
Thank you for review. Updated webrev is here:<br>
<a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Elmesnik/8156032/webrev.01/">http://cr.openjdk.java.net/~lmesnik/8156032/webrev.01/</a><br>
</blockquote>
<br>
Looks good.<br>
<br>
Thanks,<br>
StefanK<br>
<br>
<blockquote cite="mid:57596179.5070407@oracle.com" type="cite"> <br>
See comments inline:<br>
<br>
<div class="moz-cite-prefix">On 08.06.2016 17:21, Stefan Karlsson
wrote:<br>
</div>
<blockquote cite="mid:57582A02.10901@oracle.com" type="cite">Hi
Leonid, <br>
<br>
Thanks for cleaning this up! <br>
<br>
See comments inlined: <br>
<br>
On 2016-06-07 15:35, Leonid Mesnik wrote: <br>
<blockquote type="cite">Hi <br>
<br>
Could you please review following patch which remove PS
specific code from vm/gc/shared. <br>
Webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Elmesnik/8156032/webrev.00/">http://cr.openjdk.java.net/~lmesnik/8156032/webrev.00/</a>
<a moz-do-not-send="true" class="moz-txt-link-rfc2396E"
href="http://cr.openjdk.java.net/%7Elmesnik/8156032/webrev.00/"><http://cr.openjdk.java.net/%7Elmesnik/8156032/webrev.00/></a>
<br>
Bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8156032">https://bugs.openjdk.java.net/browse/JDK-8156032</a>
<br>
</blockquote>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Elmesnik/8156032/webrev.00/src/share/vm/gc/parallel/psPromotionManager.cpp.udiff.html">http://cr.openjdk.java.net/~lmesnik/8156032/webrev.00/src/share/vm/gc/parallel/psPromotionManager.cpp.udiff.html</a>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Elmesnik/8156032/webrev.00/src/share/vm/gc/shared/preservedMarks.hpp.udiff.html">http://cr.openjdk.java.net/~lmesnik/8156032/webrev.00/src/share/vm/gc/shared/preservedMarks.hpp.udiff.html</a>
<br>
<br>
+class PSPreservedMarksTaskExecutor : public
RestorePreservedMarksTaskExecutor <br>
<br>
+class SharedPreservedMarksTaskExecutor : public
RestorePreservedMarksTaskExecutor <br>
<br>
<br>
Should the subclasses also mention the word Restore? <br>
</blockquote>
Fixed. <br>
<blockquote cite="mid:57582A02.10901@oracle.com" type="cite"> <br>
------ <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Elmesnik/8156032/webrev.00/src/share/vm/gc/shared/preservedMarks.hpp.udiff.html">http://cr.openjdk.java.net/~lmesnik/8156032/webrev.00/src/share/vm/gc/shared/preservedMarks.hpp.udiff.html</a>
<br>
<br>
+public: <br>
+ WorkGang* workers; <br>
+ <br>
<br>
<br>
workers should be private and named _workers. <br>
</blockquote>
Fixed. Also PSRestorePreservedMarksTaskExecutor is updated to have
_gc_task_manager as a private member.
<meta http-equiv="content-type" content="text/html; charset=utf-8">
<blockquote cite="mid:57582A02.10901@oracle.com" type="cite"> <br>
--- <br>
<br>
+ void restore(PreservedMarksSet* preserved_marks_set, <br>
+ volatile size_t* total_size_addr); <br>
<br>
Would you mind aligning the parameters? <br>
</blockquote>
Done.<br>
<blockquote cite="mid:57582A02.10901@oracle.com" type="cite"> <br>
--- <br>
<br>
+ // Iterate over all stacks, restore all preserved marks, and
reclaim <br>
+ // the memory taken up by the stack segments. <br>
+ // Supported executors: WorkerPresevedMarksTaskExecutor
(Serial, CMS, G1), <br>
+ // PSManagerTaskExecutor (PS). <br>
<br>
<br>
The comment refers to the old names of subclasses of
RestorePreservedMarksTaskExecutor. <br>
</blockquote>
Comments have been updated with current names.<br>
<br>
Leonid<br>
<blockquote cite="mid:57582A02.10901@oracle.com" type="cite"> <br>
Thanks, <br>
StefanK <br>
<br>
<blockquote type="cite"> <br>
Fix is tested with JPRT. <br>
<br>
Leonid <br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>