<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hello,<br>
<br>
During the review period of this CR a couple of changes adding new
requires properties were integrated:<br>
8157831: vm.simpleArch <br>
8158412: vm.flightRecorder<br>
<br>
Merged variant:<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dfazunen/8151283/webrev.02/">http://cr.openjdk.java.net/~dfazunen/8151283/webrev.02/</a><br>
<br>
Thanks,<br>
Dima<br>
<br>
<br>
<div class="moz-cite-prefix">On 16.06.2016 16:34, Dmitry Fazunenko
wrote:<br>
</div>
<blockquote
cite="mid:d298242a-942b-59bb-1415-16ca43340a6f@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
Hi Michail,<br>
<br>
This is TEST.ROOT file, which defines itself what is the root for
libraries:<br>
<pre> 48 # Path to libraries in the topmost test directory. This is needed so @library
49 # does not need ../../ notation to reach them
50 external.lib.roots = ../../
</pre>
So, for the stuff like VMProps we need to use "../.." in paths<br>
<br>
Thanks,<br>
Dima<br>
<br>
<div class="moz-cite-prefix">On 16.06.2016 16:20, Michail Chernov
wrote:<br>
</div>
<blockquote cite="mid:5762A7A6.5050506@oracle.com" type="cite">
<meta content="text/html; charset=utf-8"
http-equiv="Content-Type">
Hi Dima,<br>
<br>
I have a question about paths:<br>
<br>
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: start; text-indent: 0px; text-transform: none; widows: 1; word-spacing: 0px; -webkit-text-stroke-width: 0px; word-wrap: break-word; white-space: pre-wrap;"> requires.extraPropDefns = ../../test/jtreg-ext/requires/VMProps.java
-requires.properties=sun.arch.data.model
+requires.extraPropDefns.bootlibs = ../../test/lib/sun</pre>
<br>
Do we need to use relative paths instead of full? We use full
path in tests:<br>
<br>
TestSmallHeap.java: * @library /testlibrary /test/lib
/test/lib/share/classes<br>
<br>
Thanks,<br>
Michail<br>
<br>
<div class="moz-cite-prefix">On 06/14/2016 07:14 PM, Dmitry
Fazunenko wrote:<br>
</div>
<blockquote
cite="mid:0d04fb34-8103-9007-e15f-0e04521b6496@oracle.com"
type="cite">Hi Stefan, <br>
<br>
The idea of 'vm.gc.X.acceptable' was an ability to introduce
other GC related properties like 'supported', 'default',
'setByErgonomics', 'deprecated', etc. <br>
But setting 'vm.gc.X' won't prevent us from adding
'vm.gc.X.Y' later when needed. <br>
<br>
I fully agree: @requires vm.gc.G1 looks much nicer and
causes less questions. <br>
<br>
New edition: <br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edfazunen/8151283/webrev.01/">http://cr.openjdk.java.net/~dfazunen/8151283/webrev.01/</a>
<br>
<br>
Thanks for suggestion that, <br>
Dima <br>
<br>
<br>
On 13.06.2016 10:46, Stefan Johansson wrote: <br>
<blockquote type="cite">Hi Dima, <br>
<br>
I don't know the code and the way this is invoked good
enough to do a proper review, but I have a style comment.
Wouldn't it be nice to only call the value "vm.gc.G1", and
have: <br>
@requires vm.gc.G1 <br>
<br>
I feel that "acceptable" provide very little information and
what we want to @require is that the test is only run with
G1 (when supported) and I think that is clear from such
syntax. Comments? <br>
<br>
Thanks, <br>
Stefan <br>
<br>
On 2016-06-10 18:04, Dmitry Fazunenko wrote: <br>
<blockquote type="cite">Hello, <br>
<br>
I'm looking for a couple of Reviewers for a simple change,
which allows to skip tests depending on non supported
garbage collectors. <br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edfazunen/8151283/webrev.00/">http://cr.openjdk.java.net/~dfazunen/8151283/webrev.00/</a>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8151283">https://bugs.openjdk.java.net/browse/JDK-8151283</a>
<br>
<br>
The fix introduces four new requires boolean properties: <br>
vm.gc.G1.acceptable <br>
vm.gc.Serial.acceptable <br>
vm.gc.Parallel.acceptable <br>
vm.gc.ConcMarkSweep.acceptable <br>
Which are set by the jtreg plugin prior the test execution
starts. <br>
After that fix we will be able to replace in tests: <br>
@requires vm.gc == null | vm.gc == "G1" <br>
with <br>
@requires vm.gc.G1.acceptable <br>
<br>
'vm.gc.G1.acceptable' will be evaluated to 'false' not
only if other GC is set externally, but also if G1 is not
supported. <br>
In other words the fix allows not to run GC specific tests
in not applicable configurations. <br>
<br>
Thanks, <br>
Dima <br>
<br>
<br>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>