<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<br>
<br>
<div class="moz-cite-prefix">On 21.06.2016 15:00, Thomas Schatzl
wrote:<br>
</div>
<blockquote cite="mid:1466510425.2695.59.camel@oracle.com"
type="cite">
<pre wrap="">Hi Dmitry,
On Tue, 2016-06-21 at 14:53 +0300, Dmitry Fazunenko wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Igor, Thomas
Thanks for the comments:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dfazunen/8151283/webrev.03/">http://cr.openjdk.java.net/~dfazunen/8151283/webrev.03/</a>
Because the change is small, I do not publish the diff between
version.
</pre>
</blockquote>
<pre wrap="">
could you comment on what you changed?</pre>
</blockquote>
<br>
Sorry, <br>
a added a note about <br>
<pre><span class="new"> 36 # Note: compiled bootlibs code will be located in the folder 'bootClasses'</span></pre>
And removed unused WB field.<br>
<br>
Thanks,<br>
Dima<br>
<br>
<br>
<blockquote cite="mid:1466510425.2695.59.camel@oracle.com"
type="cite">
<pre wrap="">
</pre>
<blockquote type="cite">
<pre wrap="">Thanks,
Dima
On 21.06.2016 13:34, Thomas Schatzl wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Hi,
On Tue, 2016-06-21 at 00:29 +0300, Dmitry Fazunenko wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Igor,
Thanks a lot for the review!
On 20.06.2016 23:35, Igor Ignatyev wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Dima,
the fix looks good to me, thanks for implementing that. I have
a
question about -Xbootclasspath/a:bootClasses, is it required? I
thought classes from requires.extraPropDefns.bootlibs will be
added
to BCP by jtreg.
</pre>
</blockquote>
<pre wrap="">
Yes, it's required. We might decided for example to use
-Xbootclasspath/p: instead.
bootClasses - is the name of the local folder (under scratch dir)
where classes from the 'requires.extraPropDefns.bootlibs' will
be
compiled to.
And I haven't mentioned, that I introduced a field, which is
currently unused:
private static final WhiteBox WB = WhiteBox.getWhiteBox();
This is for the simplification of use in the future.
</pre>
</blockquote>
<pre wrap=""> thanks for clarifying this - I asked myselves for the reason of
that
option too.
I would prefer to have unused code in the change at hand unless
unavoidable.
</pre>
</blockquote>
</blockquote>
<pre wrap="">
... and I forgot a "not" here.
I would prefer to not have completely unused code added to a change. If
it is required for some further change, there should be no problem
adding it there.
Thanks,
Thomas
</pre>
</blockquote>
<br>
</body>
</html>