<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Joe,<br>
<br>
Looks good. One minor point.<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jprovino/8071770/webrev.01/src/share/vm/gc/g1/g1CollectedHeap.cpp.frames.html">http://cr.openjdk.java.net/~jprovino/8071770/webrev.01/src/share/vm/gc/g1/g1CollectedHeap.cpp.frames.html</a><br>
<br>
I think the comment<br>
<br>
<pre><span class="changed">2477 // See the notes in GenCollectedHeap::millis_since_last_gc() </span>
<span class="changed">2478 // for more information about the implementation.
</span></pre>
<span class="changed">explains why the test is needed.<br>
<br>
</span>
<pre><span class="changed">2483 if (ret_val < 0) {</span>
<span class="changed">2484 log_warning(gc)("millis_since_last_gc() would return : " JLONG_FORMAT</span>
<span class="changed">2485 ". returning zero instead.", ret_val);</span>
2486 return 0;
<span class="new">2487 }</span></pre>
<br>
so it might be better if the comment is after the "if"<br>
<br>
<pre><span class="changed">2483 if (ret_val < 0) {</span><span class="changed">
2477 // See the notes in GenCollectedHeap::millis_since_last_gc() </span>
2478 // for more information about the implementation.
</pre>
<span class="changed"></span>You can decide. I don't need another
webrev.<br>
<br>
Jon<br>
<br>
<br>
<div class="moz-cite-prefix">On 07/25/2016 08:48 AM, Joseph Provino
wrote:<br>
</div>
<blockquote
cite="mid:f41d198d-929c-2771-988d-098cdba9710e@oracle.com"
type="cite">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<p>I just need one more review. ;-)</p>
<p><br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejprovino/8071770/webrev.01">http://cr.openjdk.java.net/~jprovino/8071770/webrev.01</a>
<br>
</p>
<p><a moz-do-not-send="true" class="issue-link"
data-issue-key="JDK-8071770"
href="https://bugs.openjdk.java.net/browse/JDK-8071770"
id="key-val" rel="4765897" style="color: rgb(59, 115, 175);
text-decoration: none;">JDK-8071770</a> G1 does not implement
millis_since_last_gc which is needed by RMI GC </p>
<p>joe<br>
</p>
<br>
<div class="moz-cite-prefix">On 7/25/2016 10:55 AM, Thomas Schatzl
wrote:<br>
</div>
<blockquote cite="mid:1469458504.4325.29.camel@oracle.com"
type="cite">
<pre wrap="">Hi Joe,
On Mon, 2016-07-25 at 10:49 -0400, Joseph Provino wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Can I remove the space after the word "be"?
Do you want to see another webrev?
thanks.
joe
log_warning(gc)("Detected clock going backwards. "
"Milliseconds since last GC would be " JLONG_FORMAT
". returning zero instead.", ret_val);
log_warning(gc)("Detected clock going backwards. "
"Milliseconds since last GC would be " JLONG_FORMAT
". returning zero instead.", retVal);
</pre>
</blockquote>
<pre wrap=""> No. Ship it. :)
Thomas
</pre>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>