<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Latest Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jprovino/8164482/webrev.01">http://cr.openjdk.java.net/~jprovino/8164482/webrev.01</a></p>
<ol class="aui-nav aui-nav-breadcrumbs __skate" style="margin: 0px;
list-style: none; padding: 0px;">
<li style="list-style: none; margin: 0px; padding: 0px 10px;
float: none; position: relative; display: inline;"><a
class="issue-link" data-issue-key="JDK-8164482"
href="https://bugs.openjdk.java.net/browse/JDK-8164482"
id="key-val" rel="4898003" style="color: rgb(59, 115, 175);
text-decoration: none;">JDK-8164482</a><span style="color:
rgb(51, 51, 51); font-family: sans-serif; font-size: 24px;
font-style: normal; font-variant-ligatures: normal;
font-variant-caps: normal; font-weight: normal;
letter-spacing: normal; line-height: 30px; orphans: 2;
text-align: left; text-indent: 0px; text-transform: none;
white-space: normal; widows: 2; word-spacing: 0px;
-webkit-text-stroke-width: 0px; display: inline !important;
float: none; background-color: rgb(245, 245, 245);"> [REDO] G1
does not implement millis_since_last_gc which is needed by RMI
GC</span><br class="Apple-interchange-newline">
</li>
</ol>
<p>Tests: JPRT. Also, I put in a log message for testing. It
calls millis_since_last_gc() before each collection. This will be
removed before pushing. The messages printed show millis since
last gc always >= 0 and the warning message is never printed.<br>
</p>
thanks.<br>
<br>
joe<br>
<br>
<div class="moz-cite-prefix">On 9/5/2016 7:25 AM, Thomas Schatzl
wrote:<br>
</div>
<blockquote cite="mid:1473074736.4588.50.camel@oracle.com"
type="cite">
<pre wrap="">Hi,
On Mon, 2016-09-05 at 13:17 +0200, Thomas Schatzl wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi again,
On Mon, 2016-09-05 at 13:13 +0200, Thomas Schatzl wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Hi,
On Fri, 2016-09-02 at 09:40 -0400, Joseph Provino wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Please review this small change.
JDK-8164482 [REDO] G1 does not implement millis_since_last_gc
which
is needed by RMI GC
webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jprovino/8164482/webrev.00">http://cr.openjdk.java.net/~jprovino/8164482/webrev.00</a>
</pre>
</blockquote>
<pre wrap=""> looks good.
</pre>
</blockquote>
<pre wrap=""> after having another look, I do not think the change is
good: millis_since_last_gc() tracks the time since any last gc
(probably collection pause), so the last gc time needs to be updated
at the end of every gc, not only full gcs.
The member and the getter name should also reflect this.
</pre>
</blockquote>
<pre wrap="">
also, what kind of testing did this change go through?
Please always mention this during the first review request email.
Thanks,
Thomas
</pre>
</blockquote>
<br>
</body>
</html>