<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Creating a jtreg test is more complicated than expected because
sun.rmi.transport.GC is not public.</p>
<p>Reflection could be used or millis_since_last_gc() could be made
accessible through WhiteBox.</p>
<p>But Dima says the correct way is a test in GTest format for
G1CollectedHeap::millis_since_last_gc().
<br>
But this case requires an initialized VM, and for the time being
our GTest mechanism doesn't support such cases, it supports only
native unit tests. <br>
</p>
<p>So I'd like to file an RFE for a regression test and push the fix
for 8164482.</p>
<p>Could I get two reviews for this?</p>
<p> <a class="moz-txt-link-freetext" href="https://bugs.openj">https://bugs.openj</a>dk.java.net/browse/JDK-8164482<br>
<br>
<a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Ejprovino/8164482/webrev.01">http://cr.openjdk.java.net/~jprovino/8164482/webrev.01</a></p>
<p>Thanks.</p>
<p>joe</p>
<br>
<div class="moz-cite-prefix">On 9/8/2016 10:18 AM, Thomas Schatzl
wrote:<br>
</div>
<blockquote cite="mid:1473344284.4475.142.camel@oracle.com"
type="cite">
<pre wrap="">Hi Joe,
On Thu, 2016-09-08 at 09:54 -0400, Joseph Provino wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Latest Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~jprovino/8164482/webrev.0">http://cr.openjdk.java.net/~jprovino/8164482/webrev.0</a>
1
JDK-8164482 [REDO] G1 does not implement millis_since_last_gc which
is needed by RMI GC
Tests: JPRT. Also, I put in a log message for testing. It calls
millis_since_last_gc() before each collection. This will be removed
before pushing. The messages printed show millis since last gc
always >= 0 and the warning message is never printed.
thanks.
</pre>
</blockquote>
<pre wrap="">
I think this looks good. Could you also write a small test that calls
sun.misc.GC.maxObjectInspectionAge() (or wherever it has been moved in
jdk9, it should be in sun.rmi.transport now?) to verify that no gc
returns 0 after a GC (and some artificial pause)?
Using whitebox to issue full/young gcs directly should make that fairly
easy.
Thanks,
Thomas
</pre>
</blockquote>
<br>
</body>
</html>