<html><head><style type='text/css'>p { margin: 0; }</style></head><body><div style='font-family: Times New Roman; font-size: 12pt; color: #000000'>Hi Leonid,<br><br>(not a reviewer) Maybe a comment explaining why the metaspace should be eaten first could be useful? <br>Otherwise it might be not clear that the order of the methods is important and the methods can be unintentionally swapped again?<br><br>Best regards,<br>Alexander<br><br><br>----- Original Message -----<br>From: leonid.mesnik@oracle.com<br>To: serviceability-dev@openjdk.java.net<br>Cc: hotspot-gc-dev@openjdk.java.net<br>Sent: Tuesday, October 4, 2016 11:26:33 AM GMT +03:00 Iraq<br>Subject: RFR(XS): 8155570: serviceability/tmtools/jstat/GcTest02.java fails with parallel GC<br><br>
<div>
<p>Hi</p>
<p>Could you please review following fix:</p>
<p>Webrev: <a href="http://cr.openjdk.java.net/%7Elmesnik/8155570/webrev.00/" target="_blank">http://cr.openjdk.java.net/~lmesnik/8155570/webrev.00/</a></p>
<p>Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8155570" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8155570</a></p>
<p>Test filled java heap up to 70% and then failed with OOME in the
java heap while filling metaspace. I updated test to fill
metaspace first and then to fill heap. Also I added more info
about unexpected OOME.<br>
</p>
<p>I verified locally that OOME doesn't happen now on my local host
with all GC. Unfortunately I haven't run it yet in the lab because
of infra outage. Also test still might fail because of jcmd/jstat
crash caused by <a class="issue-link" href="https://bugs.openjdk.java.net/browse/JDK-8166364" id="key-val" rel="4901447" target="_blank"><br>
</a></p>
<p><a class="issue-link" href="https://bugs.openjdk.java.net/browse/JDK-8166364" id="key-val" rel="4901447" target="_blank">JDK-8166364</a> fatal error:
acquiring lock DirtyCardQ_CBL_mon/16 out of order with lock
Module_lock/6 -- possible deadlock</p>
<p><br>
</p>
<p>Leonid<br>
</p>
<p><br>
</p>
</div>
</div></body></html>