<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Let me put following comment in eatMetaspaceAndHeap method:<br>
</p>
<p><br>
</p>
<pre> @Override
public void eatMetaspaceAndHeap(float targetMemoryUsagePercent) {
+ // Metaspace should be filled before Java Heap to prevent unexpected OOME
+ // in the Java Heap while filling Metaspace
+ eatenMetaspace = eatMetaspace(targetMemoryUsagePercent);
eatenMemory = eatHeapMemory(targetMemoryUsagePercent);
- eatenMetaspace = eatMetaspace(targetMemoryUsagePercent);
}
</pre>
Leonid<br>
<br>
<div class="moz-cite-prefix">On 05.10.2016 14:10, Alexander
Kulyakhtin wrote:<br>
</div>
<blockquote cite="mid:e776e394-0c24-4d4e-a7d2-85af4c6dbd43@default"
type="cite">
<style type="text/css">p { margin: 0; }</style>
<div style="font-family: Times New Roman; font-size: 12pt; color:
#000000">Hi Leonid,<br>
<br>
(not a reviewer) Maybe a comment explaining why the metaspace
should be eaten first could be useful? <br>
Otherwise it might be not clear that the order of the methods is
important and the methods can be unintentionally swapped again?<br>
<br>
Best regards,<br>
Alexander<br>
<br>
<br>
----- Original Message -----<br>
From: <a class="moz-txt-link-abbreviated" href="mailto:leonid.mesnik@oracle.com">leonid.mesnik@oracle.com</a><br>
To: <a class="moz-txt-link-abbreviated" href="mailto:serviceability-dev@openjdk.java.net">serviceability-dev@openjdk.java.net</a><br>
Cc: <a class="moz-txt-link-abbreviated" href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a><br>
Sent: Tuesday, October 4, 2016 11:26:33 AM GMT +03:00 Iraq<br>
Subject: RFR(XS): 8155570:
serviceability/tmtools/jstat/GcTest02.java fails with parallel
GC<br>
<br>
<div>
<p>Hi</p>
<p>Could you please review following fix:</p>
<p>Webrev: <a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Elmesnik/8155570/webrev.00/"
target="_blank">http://cr.openjdk.java.net/~lmesnik/8155570/webrev.00/</a></p>
<p>Bug: <a moz-do-not-send="true"
href="https://bugs.openjdk.java.net/browse/JDK-8155570"
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8155570</a></p>
<p>Test filled java heap up to 70% and then failed with OOME
in the java heap while filling metaspace. I updated test to
fill metaspace first and then to fill heap. Also I added
more info about unexpected OOME.<br>
</p>
<p>I verified locally that OOME doesn't happen now on my local
host with all GC. Unfortunately I haven't run it yet in the
lab because of infra outage. Also test still might fail
because of jcmd/jstat crash caused by <a
moz-do-not-send="true" class="issue-link"
href="https://bugs.openjdk.java.net/browse/JDK-8166364"
id="key-val" rel="4901447" target="_blank"><br>
</a></p>
<p><a moz-do-not-send="true" class="issue-link"
href="https://bugs.openjdk.java.net/browse/JDK-8166364"
id="key-val" rel="4901447" target="_blank">JDK-8166364</a>
fatal error: acquiring lock DirtyCardQ_CBL_mon/16 out of
order with lock Module_lock/6 -- possible deadlock</p>
<p><br>
</p>
<p>Leonid<br>
</p>
<p><br>
</p>
</div>
</div>
</blockquote>
<br>
</body>
</html>