<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Thomas,<br>
<br>
A few more comments about the tests:<br>
<br>
1) would you fix indention to meet "4-space" rule for java.<br>
2) TestParallelAlwaysPreTouch.java<br>
<br>
a)<br>
<pre>@run main ...
-->
@run main/othervm ...
b) You start one class, but declare another:
* @run main -Xms10M -Xmx100m ... <b>TestAlwaysPreTouch</b>
public class <b>Test2GbHeap </b>{
...
}
c) Would it make sense to run a group of existing tests with "-XX:+AlwaysPreTouch" regularly (nightly or weekly)
Thanks,
Dima
</pre>
<div class="moz-cite-prefix">On 18.11.2016 15:40, Thomas Schatzl
wrote:<br>
</div>
<blockquote cite="mid:1479472831.3334.21.camel@oracle.com"
type="cite">
<pre wrap="">Hi,
thanks for you looking into this...
On Fri, 2016-11-18 at 15:24 +0300, Dmitry Dmitriev wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Thomas,
Can comment only new test
test/gc/g1/TestSharedArchiveWithPreTouch.java:
1) Can you please use different name for archive to avoid
intersection
with existing tests? E.g. "SharedArchiveWithPreTouch.jsa" instead of
"CDSCompressedKPtrs.jsa".
</pre>
</blockquote>
<pre wrap="">
Will fix and rerun jprt. I copy&pasted the name from the other tests :)
</pre>
<blockquote type="cite">
<pre wrap="">2) Just interesting: Is it intended behavior of the test to use
UseCompressedClassPointers and UseCompressedOops?
</pre>
</blockquote>
<pre wrap="">
CDS is only supported with both options enabled on 64 bit systems. So
the test needs to enable them manually.
Thanks,
Thomas
</pre>
</blockquote>
<br>
</body>
</html>