<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Dima,<br>
<br>
The fix looks good to me!<br>
<br>
Minor issues:<br>
test/gc/testlibrary/Helpers.java - redundant line 338, extra space
after method comment end.<br>
Could you please fix it before pushing? I don't need a separate
review for this minor issues.<br>
<br>
Thanks,<br>
Michail<br>
<br>
<div class="moz-cite-prefix">On 08/12/2016 15:47, Dmitry Fazunenenko
wrote:<br>
</div>
<blockquote
cite="mid:cf0e2bb6-34ac-fd57-28ee-b79f1c9cf165@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
Hello,<br>
<br>
I'm looking for a couple of reviewers for a simple fix which
eliminates the code copied from Stack Overflow:<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edfazunen/8170860/webrev.00/">http://cr.openjdk.java.net/~dfazunen/8170860/webrev.00/</a><br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8170860">https://bugs.openjdk.java.net/browse/JDK-8170860</a><br>
<br>
humanReadableByteCount() method was removed. A standard JDK class
<span class="new">NumberFormat is used instead. To make the output
locale independent '_' symbol is explicitly set as the group
delimiter. New output will look like:<br>
</span><br>
<span class="new">[allocate #1 ] init: 33_554_432,
used: 5_253_664, comm: 8_388_608, freeRatio ~= 37.4%<br>
[allocate #2 ] init: 33_554_432, used: 8_399_392,
comm: 10_485_760, freeRatio ~= 19.9%<br>
[allocate #3 ] init: 33_554_432, used: 11_545_120,
comm: 13_631_488, freeRatio ~= 15.3%<br>
[allocate #4 ] init: 33_554_432, used: 14_690_848,
comm: 16_777_216, freeRatio ~= 12.4%<br>
[allocate #5 ] init: 33_554_432, used: 17_836_576,
comm: 19_922_944, freeRatio ~= 10.5%<br>
[allocate #6 ] init: 33_554_432, used: 20_982_304,
comm: 23_068_672, freeRatio ~= 9.0%<br>
[allocate #7 ] init: 33_554_432, used: 24_128_032,
comm: 26_214_400, freeRatio ~= 8.0%<br>
[allocate #8 ] init: 33_554_432, used: 27_273_760,
comm: 29_360_128, freeRatio ~= 7.1%<br>
<br>
Thanks,<br>
Dima<br>
</span> </blockquote>
<br>
</body>
</html>