<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<p>Hi Dima,</p>
<p>The change looks good to me.</p>
<p>Misha<br>
</p>
<br>
<div class="moz-cite-prefix">On 09.01.2017 16:50, Dmitry Fazunenko
wrote:<br>
</div>
<blockquote
cite="mid:b67824f2-afea-b98b-97b7-416c96ea346b@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html; charset=utf-8">
Hi in the new year!<br>
<br>
I got off line comment from Igor I. that Xmx is not needed here
at all. <br>
And I agree with Igor. <br>
GCBasher test was written many years ago, probably in those times
when default maximum heap size was 64MB.<br>
So, specifying Xmx was necessary to increase heap to allocate such
a big structure.<br>
Nowadays, it's hard to find a host where maximum heap size set by
the ergonomics will be less than 256MB. <br>
GCBasher doesn't try to allocate all available memory, it just
allocates a big structure several time. <br>
So, I think -Xmx option could be removed from this test:<br>
<br>
<a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Edfazunen/8169643/webrev.02/">http://cr.openjdk.java.net/~dfazunen/8169643/webrev.02/</a><br>
<br>
Tested by RBT with and without -XX:-UseCompressedOpps<br>
<br>
<br>
Thanks,<br>
Dima<br>
<br>
<div class="moz-forward-container"><br>
<br>
-------- Forwarded Message --------
<table class="moz-email-headers-table" border="0"
cellpadding="0" cellspacing="0">
<tbody>
<tr>
<th align="RIGHT" valign="BASELINE" nowrap="nowrap">Subject:
</th>
<td>RFR (XXS): 8169643: [TESTBUG] GCBasher test fails with
G1, CMS and Serial.</td>
</tr>
<tr>
<th align="RIGHT" valign="BASELINE" nowrap="nowrap">Date:
</th>
<td>Thu, 29 Dec 2016 17:25:26 +0300</td>
</tr>
<tr>
<th align="RIGHT" valign="BASELINE" nowrap="nowrap">From:
</th>
<td>Dmitry Fazunenenko <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:dmitry.fazunenko@oracle.com"><dmitry.fazunenko@oracle.com></a></td>
</tr>
<tr>
<th align="RIGHT" valign="BASELINE" nowrap="nowrap">To: </th>
<td>hotspot-gc-dev <a moz-do-not-send="true"
class="moz-txt-link-rfc2396E"
href="mailto:hotspot-gc-dev@openjdk.java.net"><hotspot-gc-dev@openjdk.java.net></a></td>
</tr>
</tbody>
</table>
<br>
<br>
<pre>Hi everyone,
I'm looking for a couple of review for a simple change in test: -Xmx128m
-> -Xmx256m
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/%7Edfazunen/8169643/webrev.00/">http://cr.openjdk.java.net/~dfazunen/8169643/webrev.00/</a>
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8169643">https://bugs.openjdk.java.net/browse/JDK-8169643</a>
The GCBasher test fails with OOM if run with -XX:-UseCompressedOpps.
The root cause is 128Mb is not enough to locate a big structure if Opps
are not compressed.
Giving more memory fixes the problem (TestGCBasherWithParallel.java
specifies 256m and doesn't fail)
Thanks,
Dima
</pre>
</div>
</blockquote>
<br>
</body>
</html>