<html>
<head>
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
For the record, the final version of change:<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dfazunen/8169643/webrev.03/">http://cr.openjdk.java.net/~dfazunen/8169643/webrev.03/</a><br>
<br>
<br>
Thanks<br>
Dima<br>
PS: <a href="https://bugs.openjdk.java.net/browse/JDK-8172556"
style="color: #3b73af; text-decoration: none">JDK-8172556</a> was
submitted for the further improvement.<br>
<br>
<br>
<div class="moz-cite-prefix">On 10.01.2017 22:58, Thomas Schatzl
wrote:<br>
</div>
<blockquote cite="mid:1484078301.3755.0.camel@oracle.com"
type="cite">
<pre wrap="">Hi Dima,
On Tue, 2017-01-10 at 19:09 +0300, Dmitry Fazunenko wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Thomas,
On 09.01.2017 17:38, Thomas Schatzl wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Hi,
On Mon, 2017-01-09 at 16:50 +0300, Dmitry Fazunenko wrote:
</pre>
<blockquote type="cite">
<pre wrap="">
Hi in the new year!
I got off line comment from Igor I. that Xmx is not needed here
at
all.
And I agree with Igor.
GCBasher test was written many years ago, probably in those times
when default maximum heap size was 64MB.
So, specifying Xmx was necessary to increase heap to allocate
such a
big structure.
Nowadays, it's hard to find a host where maximum heap size set by
the
ergonomics will be less than 256MB.
GCBasher doesn't try to allocate all available memory, it just
allocates a big structure several time.
So, I think -Xmx option could be removed from this test:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dfazunen/8169643/webrev.02/">http://cr.openjdk.java.net/~dfazunen/8169643/webrev.02/</a>
Tested by RBT with and without -XX:-UseCompressedOpps
</pre>
</blockquote>
<pre wrap=""> I think the limitation has been introduced so that gcbasher does
something useful, i.e. execute enough GCs. With a multi-GB heap at
its
disposal, I expect that the amount of GCs executed will be
significantly lower than it is now.
</pre>
</blockquote>
<pre wrap="">Your arguments do certainly make sense.
</pre>
<blockquote type="cite">
<pre wrap="">
I prefer to have a 256M limit to none; and maybe the test could be
run
once with and without UseCompressedOops with appropriate heap sizes
instead if there is enough cpu time in our testing infrastructure.
</pre>
</blockquote>
<pre wrap="">I suggest to start with original version of the fix:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~dfazunen/8169643/webrev.00/">http://cr.openjdk.java.net/~dfazunen/8169643/webrev.00/</a>
(+ copyright updates)
and submit an RFE to limit max heap size depending of
UseCompressedOops
value.
Such RFE could implemented much easily after integration of
JDK-8172417 Verundy: Library to simplify using TestNG for
Hotspot test development
Now it's a bit tricky to get known from the test the values of
external tags.
Are you okay with that?
</pre>
</blockquote>
<pre wrap="">
yes, thanks.
Thomas
</pre>
</blockquote>
<br>
</body>
</html>