<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Kim and Thomas,<br>
<br>
Here's webrev.2 with Thomas' comment version.<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~sangheki/8173013/webrev.2">http://cr.openjdk.java.net/~sangheki/8173013/webrev.2</a><br>
<br>
--------------------<br>
<pre><span class="new">1538 #if INCLUDE_ALL_GCS</span>
<span class="new">1539 if (UseG1GC) {</span>
<span class="new">1540 // The reference in this tag map could be the only (implicitly weak)</span>
<span class="new">1541 // reference to that object. If we hand it out, we need to keep it live wrt</span>
<span class="new">1542 // SATB marking similar to other j.l.ref.Reference referents.</span>
<span class="new">1543 G1SATBCardTableModRefBS::enqueue(o);</span>
<span class="new">1544 }</span>
<span class="new">1545 #endif</span></pre>
--------------------<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
<div class="moz-cite-prefix">On 02/03/2017 01:10 PM, sangheon wrote:<br>
</div>
<blockquote
cite="mid:fa59335f-4483-2c17-9d1f-b9dd1775d51d@oracle.com"
type="cite">Hi Kim,
<br>
<br>
On 02/03/2017 01:05 PM, Kim Barrett wrote:
<br>
<blockquote type="cite">
<blockquote type="cite">On Feb 3, 2017, at 1:41 PM, sangheon
<a class="moz-txt-link-rfc2396E" href="mailto:sangheon.kim@oracle.com"><sangheon.kim@oracle.com></a> wrote:
<br>
<blockquote type="cite">"The reference in this tag map could
be the only (implicitly weak)
<br>
reference to that object. If we hand it out we need to keep
it live wrt
<br>
SATB marking similar to other j.l.ref.Reference referents."
<br>
</blockquote>
I like this comment.
<br>
If other reviewers don't have better suggestion, I will upload
the revised patch with this.
<br>
</blockquote>
Looks good with something like Thomas's improved comment.
<br>
<br>
</blockquote>
Thanks for the review and all the discussion for this CR.
<br>
And Thomas' comment is the candidate for now.
<br>
<br>
Sangheon
<br>
<br>
</blockquote>
<br>
</body>
</html>