<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Muthusamy,<br>
<br>
new change looks good to me.<br>
To make it look perfect you need to update copyrights - add 2017 :)<br>
No separate review is required for that.<br>
<br>
Thanks,<br>
Dima<br>
<br>
<div class="moz-cite-prefix">On 16.08.2017 12:59, Muthusamy
Chinnathambi wrote:<br>
</div>
<blockquote type="cite"
cite="mid:6e2dfb59-ee63-4872-8af3-b8c5c60b462b@default">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p
{mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-style-priority:99;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.new
{mso-style-name:new;}
span.EmailStyle22
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:#1F497D;}
span.EmailStyle23
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks
for the review. I did not realize the difference between the
two.<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Please
find the updated webrev at <a
href="http://cr.openjdk.java.net/%7Eshshahma/Muthu/8180366/webrev.02/"
moz-do-not-send="true">http://cr.openjdk.java.net/~shshahma/Muthu/8180366/webrev.02/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Regards,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Muthusamy
C<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><a name="_MailEndCompose"
moz-do-not-send="true"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></a></p>
<span style="mso-bookmark:_MailEndCompose"></span>
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
Dmitry Fazunenko [<a class="moz-txt-link-freetext" href="mailto:dmitry.fazunenko@gmail.com">mailto:dmitry.fazunenko@gmail.com</a>] <br>
<b>Sent:</b> Thursday, August 10, 2017 3:11 AM<br>
<b>To:</b> Muthusamy Chinnathambi
<a class="moz-txt-link-rfc2396E" href="mailto:muthusamy.chinnathambi@oracle.com"><muthusamy.chinnathambi@oracle.com></a>;
<a class="moz-txt-link-abbreviated" href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a><br>
<b>Cc:</b> David Buck <a class="moz-txt-link-rfc2396E" href="mailto:david.buck@oracle.com"><david.buck@oracle.com></a><br>
<b>Subject:</b> Re: [10] RFR (XS): 8180366: [TESTBUG]
gc/g1/humongousObjects/TestHumongousClassLoader should
not be run with class unloading disabled<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Hi Muthusamy,<o:p></o:p></p>
<p>To skip running a test if "-XX:-ClassUnloading" is given it's
better to say:<o:p></o:p></p>
<pre><span class="new">@requires vm.opt.ClassUnloading != false</span><o:p></o:p></pre>
<p class="MsoNormal" style="margin-bottom:12.0pt">This will
allow to keep the test running if no 'ClassUnloading' VM flag
is specified.<br>
<br>
Thanks,<br>
Dima<br>
<br>
<o:p></o:p></p>
<div>
<p class="MsoNormal">On 09.08.2017 14:36, Muthusamy
Chinnathambi wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>Hi,<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Please review this trivial change for the fix of bug 'JDK-8180366 [TESTBUG] gc/g1/humongousObjects/TestHumongousClassLoader should not be run with class unloading disabled'<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Summary:<o:p></o:p></pre>
<pre>This testcase(TestHumongousClassLoader.java) checks that unreachable classes and unreachable humongous class loader are unloaded after GC. Hence we need to have class unloading enabled for the correctness of the test. The fix is to prohibit execution of the test if class unloading is disabled.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>jdk10 bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8180366" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8180366</a><o:p></o:p></pre>
<pre>webrev link: <a href="http://cr.openjdk.java.net/%7Eshshahma/Muthu/8180366/webrev.00/" moz-do-not-send="true">http://cr.openjdk.java.net/~shshahma/Muthu/8180366/webrev.00/</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Testing: I have manually confirmed that jtreg will no longer run the test if -XX:-ClassUnloading is used.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Regards,<o:p></o:p></pre>
<pre>Muthusamy C<o:p></o:p></pre>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</blockquote>
<br>
</body>
</html>