<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Alex,<br>
<br>
Thanks for the review!<br>
<br>
Sangheon<br>
<br>
<br>
<div class="moz-cite-prefix">On 08/22/2017 12:01 PM, Alexander
Harlap wrote:<br>
</div>
<blockquote type="cite"
cite="mid:027acfca-14b6-1806-751b-887b60c30e55@oracle.com">
<meta content="text/html; charset=utf-8" http-equiv="Content-Type">
<p>Good change.</p>
<p>Alex<br>
</p>
<br>
<div class="moz-cite-prefix">On 8/18/2017 4:17 PM, sangheon.kim
wrote:<br>
</div>
<blockquote
cite="mid:ebf3953c-b952-5335-4799-6c446457c3b7@oracle.com"
type="cite">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
Hi all,<br>
<br>
Could I have some reviews for this tiny change of adding
ParallelGCThreads=2 in TestPrintReferences.java?<br>
<br>
The test is assuming always to have 'Balance queues:' log but it
is only generated when the VM did queue balancing. Queue
balancing happens when MT process is enabled(with
+ParallelRefProcBalancingEnabled) or MT discovery is enabled.
And MT discovery is enabled if we have multiple
ParallelGCThreads (> 1).<br>
<br>
Adding explicit thread setting of 'ParallelGCThreads=1' is
easiest way to avoid this test failure on limited environments.
i.e. machines which determine to use 1 ParallelGCThreads.<br>
<br>
The test failure log also includes:<br>
"[Java HotSpot(TM) 64-Bit Server VM warning: If the number of
processors is expected to increase from one, then you should
configure the number of parallel GC threads appropriately using
-XX:ParallelGCThreads=N"<br>
<br>
CR: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8186402">https://bugs.openjdk.java.net/browse/JDK-8186402</a><br>
Webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Esangheki/8186402/webrev.0/">http://cr.openjdk.java.net/~sangheki/8186402/webrev.0/</a><br>
Testing: JPRT<br>
<br>
Thanks,<br>
Sangheon<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>