<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Roman,<br>
<br>
Thanks for dealing with this so quickly.<br>
<br>
This part is incorrect:<br>
<pre><span class="new">+ if (collector != NULL || !collector->completed_initialization()) {</span></pre>
it used to be:<br>
<pre class="sourcelines wrap"><span id="l15.179" class="minusline">- if (collector == NULL || !collector->completed_initialization()) {
No need to add a space after the !:
</span><span class="new">if (! create_cms_collector())
Other than those to issues, this looks good.</span>
<span id="l15.179" class="minusline"></span></pre>
StefanK<br>
<br>
On 2017-10-18 19:21, Roman Kennke wrote:<br>
</div>
<blockquote type="cite"
cite="mid:bfbcf6fa-f2e8-efdf-cc79-10f07f0b9d84@redhat.com">Apperently
I yanked some error handling when extracting the CMSHeap class
from GenCollectedHeap, which makes TestOptionsWithRanges test
fail.
<br>
<br>
This puts the error handling back in exactly as it was before,
which makes the test happy:
<br>
<br>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~rkennke/8189390/webrev.00/">http://cr.openjdk.java.net/~rkennke/8189390/webrev.00/</a>
<a class="moz-txt-link-rfc2396E" href="http://cr.openjdk.java.net/%7Erkennke/8189390/webrev.00/"><http://cr.openjdk.java.net/%7Erkennke/8189390/webrev.00/></a>
<br>
<br>
Ok?
<br>
<br>
Roman
<br>
<br>
</blockquote>
<p><br>
</p>
</body>
</html>