<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Kishor,<br>
<br>
<div class="moz-cite-prefix">On 11/03/2017 11:39 AM, Kharbas, Kishor
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:F89640DCD01A85489FCBA68183A6A0F3BCD4FF76@ORSMSX116.amr.corp.intel.com">
<pre wrap="">Thanks a lot!
Link to updated webrevs -
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/</a>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/</a></pre>
</blockquote>
Thank you for fixing all.<br>
Looks good to me except below.<br>
<br>
Could you update the copyright format in TestAllocateHeapAt.java?<br>
2 * Copyright (c) 2017 Oracle and/or its affiliates. All rights
reserved.<br>
- Missing comma: * Copyright (c) 2017<u><b>,</b></u> Oracle and/or
its affiliates. All rights reserved.<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
<blockquote type="cite"
cite="mid:F89640DCD01A85489FCBA68183A6A0F3BCD4FF76@ORSMSX116.amr.corp.intel.com">
<pre wrap="">
@Sangheon: Please let me know if you see any corrections needed.
-Kishor
</pre>
<blockquote type="cite">
<pre wrap="">-----Original Message-----
From: Thomas Schatzl [<a class="moz-txt-link-freetext" href="mailto:thomas.schatzl@oracle.com">mailto:thomas.schatzl@oracle.com</a>]
Sent: Friday, November 3, 2017 7:31 AM
To: Kharbas, Kishor <a class="moz-txt-link-rfc2396E" href="mailto:kishor.kharbas@intel.com"><kishor.kharbas@intel.com></a>; sangheon.kim
<a class="moz-txt-link-rfc2396E" href="mailto:sangheon.kim@oracle.com"><sangheon.kim@oracle.com></a>; '<a class="moz-txt-link-abbreviated" href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a>'
<a class="moz-txt-link-rfc2396E" href="mailto:hotspot-gc-dev@openjdk.java.net"><hotspot-gc-dev@openjdk.java.net></a>; hotspot-runtime-
<a class="moz-txt-link-abbreviated" href="mailto:dev@openjdk.java.net">dev@openjdk.java.net</a>
Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative
memory devices and CSR review
Hi,
On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:
</pre>
<blockquote type="cite">
<pre wrap="">Hi Sangheon,
Thanks for the review and comments. Here is an updated webrev-
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12</a>
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11</a>
In addition to your suggested corrections, I added code to set Linux
core dump filter ensuring Heap is dumped correctly when this feature
is used. This is follow-up to Jini George’s comment
(<a class="moz-txt-link-freetext" href="http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap">http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap</a>-
allocation-on-alternative-memory-devices-td300109.html#a300450).
</pre>
</blockquote>
<pre wrap="">
Some minor nits:
- os_posix.cpp:300: please move the else next to the brace
- arguments.cpp:4624: please add a space between "if" and the bracket
I do not need to see a new webrev for these changes. Looks good.
Thanks,
Thomas
</pre>
</blockquote>
<pre wrap="">
</pre>
</blockquote>
<br>
</body>
</html>