<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Kishor,<br>
<br>
<br>
<div class="moz-cite-prefix">On 11/03/2017 02:59 PM, Kharbas, Kishor
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:F89640DCD01A85489FCBA68183A6A0F3BCD5008C@ORSMSX116.amr.corp.intel.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";
color:black;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:Consolas;
color:black;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Hi
Sangheon,<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Here
is link to the updated webrev-<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><a
href="http://cr.openjdk.java.net/%7Ekkharbas/8190308/webrev.14/"
moz-do-not-send="true">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14/</a><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><a
href="http://cr.openjdk.java.net/%7Ekkharbas/8190308/webrev.14_to_13/"
moz-do-not-send="true">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.14_to_13/</a></span></p>
</div>
</blockquote>
Looks good to me.<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
<blockquote type="cite"
cite="mid:F89640DCD01A85489FCBA68183A6A0F3BCD5008C@ORSMSX116.amr.corp.intel.com">
<div class="WordSection1">
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Thanks<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D">Kishor<o:p></o:p></span></p>
<p class="MsoNormal"><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in
0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1
1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><a name="_____replyseparator"
moz-do-not-send="true"></a><b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">From:</span></b><span
style="font-size:11.0pt;font-family:"Calibri",sans-serif;color:windowtext">
sangheon.kim [<a class="moz-txt-link-freetext" href="mailto:sangheon.kim@oracle.com">mailto:sangheon.kim@oracle.com</a>]
<br>
<b>Sent:</b> Friday, November 3, 2017 2:38 PM<br>
<b>To:</b> Kharbas, Kishor
<a class="moz-txt-link-rfc2396E" href="mailto:kishor.kharbas@intel.com"><kishor.kharbas@intel.com></a>; Thomas Schatzl
<a class="moz-txt-link-rfc2396E" href="mailto:thomas.schatzl@oracle.com"><thomas.schatzl@oracle.com></a>;
'<a class="moz-txt-link-abbreviated" href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a>'
<a class="moz-txt-link-rfc2396E" href="mailto:hotspot-gc-dev@openjdk.java.net"><hotspot-gc-dev@openjdk.java.net></a>;
<a class="moz-txt-link-abbreviated" href="mailto:hotspot-runtime-dev@openjdk.java.net">hotspot-runtime-dev@openjdk.java.net</a><br>
<b>Subject:</b> Re: RFR(M): 8190308: Supporting heap
allocation on alternative memory devices and CSR
review<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">Hi Kishor,<o:p></o:p></p>
<div>
<p class="MsoNormal">On 11/03/2017 11:39 AM, Kharbas, Kishor
wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>Thanks a lot!<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Link to updated webrevs -<o:p></o:p></pre>
<pre><a href="http://cr.openjdk.java.net/%7Ekkharbas/8190308/webrev.13/" moz-do-not-send="true">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13/</a><o:p></o:p></pre>
<pre><a href="http://cr.openjdk.java.net/%7Ekkharbas/8190308/webrev.13_to_12/" moz-do-not-send="true">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.13_to_12/</a><o:p></o:p></pre>
</blockquote>
<p class="MsoNormal">Thank you for fixing all.<br>
Looks good to me except below.<br>
<br>
Could you update the copyright format in
TestAllocateHeapAt.java?<br>
2 * Copyright (c) 2017 Oracle and/or its affiliates. All
rights reserved.<br>
- Missing comma: * Copyright (c) 2017<b><u>,</u></b> Oracle
and/or its affiliates. All rights reserved.<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
<br>
<o:p></o:p></p>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre><o:p> </o:p></pre>
<pre><o:p> </o:p></pre>
<pre>@Sangheon: Please let me know if you see any corrections needed.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>-Kishor<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>-----Original Message-----<o:p></o:p></pre>
<pre>From: Thomas Schatzl [<a href="mailto:thomas.schatzl@oracle.com" moz-do-not-send="true">mailto:thomas.schatzl@oracle.com</a>]<o:p></o:p></pre>
<pre>Sent: Friday, November 3, 2017 7:31 AM<o:p></o:p></pre>
<pre>To: Kharbas, Kishor <a href="mailto:kishor.kharbas@intel.com" moz-do-not-send="true"><kishor.kharbas@intel.com></a>; sangheon.kim<o:p></o:p></pre>
<pre><a href="mailto:sangheon.kim@oracle.com" moz-do-not-send="true"><sangheon.kim@oracle.com></a>; '<a href="mailto:hotspot-gc-dev@openjdk.java.net" moz-do-not-send="true">hotspot-gc-dev@openjdk.java.net</a>'<o:p></o:p></pre>
<pre><a href="mailto:hotspot-gc-dev@openjdk.java.net" moz-do-not-send="true"><hotspot-gc-dev@openjdk.java.net></a>; hotspot-runtime-<o:p></o:p></pre>
<pre><a href="mailto:dev@openjdk.java.net" moz-do-not-send="true">dev@openjdk.java.net</a><o:p></o:p></pre>
<pre>Subject: Re: RFR(M): 8190308: Supporting heap allocation on alternative<o:p></o:p></pre>
<pre>memory devices and CSR review<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Hi,<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>On Fri, 2017-11-03 at 08:55 +0000, Kharbas, Kishor wrote:<o:p></o:p></pre>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<pre>Hi Sangheon,<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Thanks for the review and comments. Here is an updated webrev-<o:p></o:p></pre>
<pre><a href="http://cr.openjdk.java.net/%7Ekkharbas/8190308/webrev.12" moz-do-not-send="true">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12</a><o:p></o:p></pre>
<pre><a href="http://cr.openjdk.java.net/%7Ekkharbas/8190308/webrev.12_to_11" moz-do-not-send="true">http://cr.openjdk.java.net/~kkharbas/8190308/webrev.12_to_11</a><o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>In addition to your suggested corrections, I added code to set Linux<o:p></o:p></pre>
<pre>core dump filter ensuring Heap is dumped correctly when this feature<o:p></o:p></pre>
<pre>is used. This is follow-up to Jini George’s comment<o:p></o:p></pre>
<pre>(<a href="http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap" moz-do-not-send="true">http://openjdk.5641.n7.nabble.com/RFR-M-8171181-Supporting-heap</a>-<o:p></o:p></pre>
<pre>allocation-on-alternative-memory-devices-td300109.html#a300450).<o:p></o:p></pre>
</blockquote>
<pre><o:p> </o:p></pre>
<pre>Some minor nits:<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre> - os_posix.cpp:300: please move the else next to the brace<o:p></o:p></pre>
<pre> - arguments.cpp:4624: please add a space between "if" and the bracket<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>I do not need to see a new webrev for these changes. Looks good.<o:p></o:p></pre>
<pre><o:p> </o:p></pre>
<pre>Thanks,<o:p></o:p></pre>
<pre> Thomas<o:p></o:p></pre>
</blockquote>
<pre><o:p> </o:p></pre>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</blockquote>
<br>
</body>
</html>