<html>
<head>
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Hi Kishor,<br>
<br>
<div class="moz-cite-prefix">On 11/13/2017 03:51 PM, Kharbas, Kishor
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:F89640DCD01A85489FCBA68183A6A0F3BCD54D7C@ORSMSX116.amr.corp.intel.com">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Hi!<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I have developed a test plan for the
implementation of 8171181.<o:p></o:p></p>
<p class="MsoNormal">I would appreciate a review and further
guidance from the gc-dev members. I am hoping to get
everything done well before 18.3 code freeze (have a vacation
planned during that time).<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Test plan: <a
href="https://bugs.openjdk.java.net/browse/JDK-8190828"
moz-do-not-send="true">
https://bugs.openjdk.java.net/browse/JDK-8190828</a><o:p></o:p></p>
<p class="MsoNormal">Test webrev: <a
href="http://cr.openjdk.java.net/%7Ekkharbas/8190980/webrev.01/"
moz-do-not-send="true">
http://cr.openjdk.java.net/~kkharbas/8190980/webrev.01/</a></p>
</div>
</blockquote>
Looking at the comment at 8190980, webrev.2 seems the latest one, so
my comments are for the webrev.2.<br>
<br>
--------------------------------------<br>
test/hotspot/jtreg/gc/TestAllocateHeapAtMultiple.java<br>
<br>
51 String[] extraOptsList = new String[] {<br>
52 "-Xmx32m -Xms32m -XX:+UseCompressedOops", // 1. With
compressedoops enabled.<br>
53 "-Xmx32m -Xms32m -XX:-UseCompressedOops", // 2. With
compressedoops disabled.<br>
54 "-Xmx32m -Xms32m -XX:HeapBaseMinAddress=3g", // 3. With
user specified HeapBaseMinAddress.<br>
55 "-Xmx4g -Xms4g", // 4. With
larger heap size (UnscaledNarrowOop not possible).<br>
56 "-Xmx4g -Xms4g -XX:+UseLargePages", // 5. Set
UseLargePages.<br>
57 "-Xmx4g -Xms4g -XX:+UseNUMA" // 6. Set
UseNUMA.<br>
58 };<br>
- I think we do differently to run sub-tests. Maybe SQE folks would
give better comment on this.<br>
e.g. TestAllocationInEden.java<br>
* @run main/othervm -Xbootclasspath/a:.
-XX:+UnlockDiagnosticVMOptions<br>
...<br>
* TestAllocationInEden 10m 9 EDEN<br>
* @run main/othervm -Xbootclasspath/a:.
-XX:+UnlockDiagnosticVMOptions<br>
...<br>
* TestAllocationInEden 10m 47 EDEN<br>
* @run main/othervm -Xbootclasspath/a:.
-XX:+UnlockDiagnosticVMOptions<br>
<br>
52 "-Xmx32m -Xms32m -XX:+UseCompressedOops", // 1. With
compressedoops enabled.<br>
54 "-Xmx32m -Xms32m -XX:HeapBaseMinAddress=3g", // 3. With
user specified HeapBaseMinAddress.<br>
55 "-Xmx4g -Xms4g", // 4. With
larger heap size (UnscaledNarrowOop not possible).<br>
- I think these 3 sub-tests are testing different compressed oop
modes. I would recommend to include other 1 type(non-zero based) as
well. In addition, adding the comment also would help increase the
readability.<br>
<br>
--------------------------------------<br>
test/hotspot/jtreg/gc/stress/gcbasher/TestGCBasherWithAllocateHeapAt.java<br>
<br>
1) This seems identical to TestGCBasherWithG1.java, how about just
adding another '@run'?<br>
i.e. adding "* @run main/othervm/timeout=500 -Xlog:gc*=info
-Xmx256m -server -XX:+UseG1GC <u><b>-XX:AllocateHeapAt=.</b></u>
TestGCBasherWithG1 120000"<br>
<br>
2) Don't we need testing for other GC types as well? i.e. Serial,
Parallel and CMS.<br>
<br>
2 * Copyright (c) 2016, 2017, Oracle and/or its affiliates. All
rights reserved.<br>
- Is this intended to start from 2016 as this seems to be copied
from TestGCBasherWithXXX.java? <br>
<br>
34 * @run main/othervm/timeout=500 -Xlog:gc*=info -Xmx256m -server
-XX:+UseG1GC -XX:AllocateHeapAt=. TestGCBasherWithAllocateHeapAt
120000<br>
- Are there any reason to use timeout of 500? TestGCBasherWithG1 is
using 200ms.<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
<br>
<blockquote type="cite"
cite="mid:F89640DCD01A85489FCBA68183A6A0F3BCD54D7C@ORSMSX116.amr.corp.intel.com">
<div class="WordSection1">
<p class="MsoNormal"><o:p></o:p></p>
<p class="MsoNormal">JEP:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8171181">https://bugs.openjdk.java.net/browse/JDK-8171181</a><o:p></o:p></p>
<p class="MsoNormal">Implementation webrev : <a
href="http://cr.openjdk.java.net/%7Ekkharbas/8190308/webrev.15/"
moz-do-not-send="true">
http://cr.openjdk.java.net/~kkharbas/8190308/webrev.15/</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thank you!<o:p></o:p></p>
<p class="MsoNormal">Kishor<o:p></o:p></p>
</div>
</blockquote>
<br>
</body>
</html>