<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">JC,<div class=""><br class=""></div><div class="">So I am the one who suggested that you ask the GC folks if they were ok with name change going in in advance,</div><div class="">since the merging includes a number of files in a rapidly changing repository. Thank you for pointing out the risks.</div><div class=""><br class=""></div><div class="">I am going to assume that this is a review for the approach, not the final source code review because:</div><div class="">- I do not see the full set of tests run - which you would coordinate with your sponsor</div><div class=""><br class=""></div><div class="">If the GC team is ok with the approach and you have all the tests passing - please send the actual code review request to</div><div class=""><a href="mailto:hotspot-dev@openjdk.java.net" class="">hotspot-dev@openjdk.java.net</a>. We use the team aliases for design consulting. We use the larger alias before anything goes in.</div><div class=""><br class=""></div><div class="">See below ...</div><div class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Apr 9, 2018, at 1:24 PM, JC Beyler <<a href="mailto:jcbeyler@google.com" class="">jcbeyler@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi all,<div class=""><br class=""></div><div class="">Small pre-amble to this request:</div><div class="">In my work to try to get a heap sampler in OpenJDK (via <a href="https://bugs.openjdk.java.net/browse/JDK-8171119" class="">JEP 331</a>), I'm trying to reduce the footprint of my change so that the integration can be easier. I was told that generally a JEP webrev should be feature complete and go in at-once. However, with the change touching quite a bit of various code pieces, I was trying to figure out what could be separated as not "part of the feature".</div><div class=""><br class=""></div><div class="">I asked around and said that perhaps a solution would be to cut up the renaming of TLAB's end field that I do in that webrev. Because I'm renaming a field in TLAB used by various backends for that work, I have to update every architecture dependent code to reflect it.</div><div class=""><br class=""></div><div class="">I entirely understand that perhaps this is not in the habits and very potentially might not be the way things are generally done. If so, I apologize and let me know if you would not want this to go in separately :)</div><div class=""><br class=""></div><div class="">Final note: there is still a chance JEP-331 does not go in. If it does not, we can leave the new name in place or I'll happily revert it. I can even create an issue to track this if that makes it easier for all.</div><div class=""><br class=""></div><div class="">End of the pre-amble.</div><div class=""><br class=""></div><div class=""><br class=""></div><div class="">The 33-line change webrev in question is here:<br class=""></div><div class=""><a href="http://cr.openjdk.java.net/~jcbeyler/8201326/webrev.00/" class="">http://cr.openjdk.java.net/~jcbeyler/8201326/webrev.00/</a><br class=""></div><div class=""><br class=""></div><div class="">I fixed all the architectures and JVMCI and ran a few sanity tests to ensure I had not missed anything.</div><div class=""><br class=""></div><div class="">Thanks for your help and I hope this is not too much trouble,</div><div class="">Jc</div><div class=""><br class=""></div><div class="">Ps: there is a graal change that needs to happen but I was not sure who/where to ask about it. I was told it could happen in a separate webrev. Can anyone point me to the right direction? Should it just be hotspot-compiler-dev?</div></div>
</div></blockquote>Can I assume the graal change is not related to 8201326, but part of the 8171119 heap sampler collection email thread? That already</div><div>includes the compiler team, so you should be set there.</div><div><br class=""></div><div>thanks,</div><div>Karen</div><br class=""></div></body></html>