<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi JC,<div class=""><br class=""></div><div class="">you should change second year instead of adding another one[*]. otherwise the fix looks good to me.</div><div class=""><br class=""></div><div class="">-- Igor</div><div class=""><br class=""></div><div class="">[*] <a href="http://mail.openjdk.java.net/pipermail/jdk7-dev/2010-May/001321.html" class="">http://mail.openjdk.java.net/pipermail/jdk7-dev/2010-May/001321.html</a><br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Jul 31, 2018, at 11:18 AM, JC Beyler <<a href="mailto:jcbeyler@google.com" class="">jcbeyler@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class="">Hi Igor,<br class=""><div class=""><br class=""></div><div class="">Here is a webrev that does the 'X == false | X == null' -> 'X != true' for all the ones I could find across the tests.</div><div class="">I also fixed the parenthesis issue.</div></div></div></blockquote><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class="">Not sure if it was important, but I updated the copyright year for files that did not have 2018.</div></div></div></blockquote><blockquote type="cite" class=""><div class=""><div dir="ltr" class=""><div class=""><br class=""></div><div class=""><a href="http://cr.openjdk.java.net/~jcbeyler/8169004/webrev.01/jdk12-test3.changeset" class="">http://cr.openjdk.java.net/~jcbeyler/8169004/webrev.01/jdk12-test3.changeset</a><br class=""></div><div class=""><br class=""></div><div class="">Let me know what you think,</div><div class="">Jc</div><div class=""><br class=""></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, Jul 31, 2018 at 9:57 AM Igor Ignatyev <<a href="mailto:igor.ignatyev@oracle.com" class="">igor.ignatyev@oracle.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi JC,<br class="">
<br class="">
would you mind removing similar redundancy in other tests? e.g. 'vm.opt.AggressiveOpts=="false" | vm.opt.AggressiveOpts=="null"' in a few test/hotspot/jtreg/gc/g1/ tests can be replaced w/ vm.opt.AggressiveOpts != true'.<br class="">
<br class="">
the parentheses around simple predicate seem redundant to me as well.<br class="">
<br class="">
Thanks,<br class="">
-- Igor<br class="">
<br class="">
> On Jul 31, 2018, at 12:38 AM, Thomas Schatzl <<a href="mailto:thomas.schatzl@oracle.com" target="_blank" class="">thomas.schatzl@oracle.com</a>> wrote:<br class="">
> <br class="">
> Hi,<br class="">
> <br class="">
> On Mon, 2018-07-30 at 12:28 -0700, JC Beyler wrote:<br class="">
>> Hi all,<br class="">
>> <br class="">
>> Could I get a few reviews for a really small webrev?<br class="">
>> <br class="">
>> Webrev: <a href="http://cr.openjdk.java.net/~jcbeyler/8169004/webrev.00/" rel="noreferrer" target="_blank" class="">http://cr.openjdk.java.net/~jcbeyler/8169004/webrev.00/</a><br class="">
>> Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8169004" rel="noreferrer" target="_blank" class="">https://bugs.openjdk.java.net/browse/JDK-8169004</a><br class="">
>> <br class="">
>> Thanks!<br class="">
>> Jc<br class="">
> <br class="">
> looks good and trivial. I will sponsor it.<br class="">
> <br class="">
> Thanks,<br class="">
> Thomas<br class="">
> <br class="">
<br class="">
</blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class=""><div class=""><br class=""></div>Thanks,<div class="">Jc</div></div></div>
</div></blockquote></div><br class=""></div></body></html>