<div dir="ltr">Hi all,<br><div><br></div><div>Here is a webrev ready for a push if someone could do it:</div><div><a href="http://cr.openjdk.java.net/~jcbeyler/8208246/webrev.01/">http://cr.openjdk.java.net/~jcbeyler/8208246/webrev.01/</a><br></div><div><br></div><div>Thanks both for the reviews!</div><div>Jc</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Jul 31, 2018 at 10:00 AM Igor Ignatyev <<a href="mailto:igor.ignatyev@oracle.com">igor.ignatyev@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div style="word-wrap:break-word;line-break:after-white-space">Hi JC,<div><br></div><div>the fix looks good to me. thanks for fixing it.</div><div><br></div><div>Cheers,</div><div>-- Igor<br><div><br><blockquote type="cite"><div>On Jul 31, 2018, at 12:49 AM, Thomas Schatzl <<a href="mailto:thomas.schatzl@oracle.com" target="_blank">thomas.schatzl@oracle.com</a>> wrote:</div><br class="m_-7218372100414749850Apple-interchange-newline"><div><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline!important">Hi,</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline!important">On Mon, 2018-07-30 at 12:34 -0700, JC Beyler wrote:</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><blockquote type="cite" style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none">Hi all,<br><br>Could I get a review for:<br><br>Webrev: <a href="http://cr.openjdk.java.net/~jcbeyler/8208246/" target="_blank">http://cr.openjdk.java.net/~jcbeyler/8208246/</a><br>Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8208246" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8208246</a><br><br>Basically, I removed the duplicate flags in the various tests.<br><br>Additional notes due to the number of files changed:<span class="m_-7218372100414749850Apple-converted-space"> </span><br> - I used an awk script to remove any duplicate line that was not<br>just a empty commented line and occurred after a line<br>containing @run.<br>  - I then ran a script to check that all lines removed from the<br>tests were still present in the test files (sanity check of my<br>script)<br>  - Finally, I ran the tests and they still pass via make run-test-<br>only on my dev machine<br><br></blockquote><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline!important"> looks good.</span><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><br style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none"><span style="font-family:Helvetica;font-size:12px;font-style:normal;font-variant-caps:normal;font-weight:normal;letter-spacing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;word-spacing:0px;text-decoration:none;float:none;display:inline!important">Thomas</span></div></blockquote></div><br></div></div></blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>