<html xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">LGTM.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Paul<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: </span></b><span style="font-size:12.0pt;color:black">JC Beyler <jcbeyler@google.com><br>
<b>Date: </b>Tuesday, August 14, 2018 at 8:22 PM<br>
<b>To: </b>"per.liden@oracle.com" <per.liden@oracle.com><br>
<b>Cc: </b>Thomas Schatzl <thomas.schatzl@oracle.com>, "Hohensee, Paul" <hohensee@amazon.com>, "hotspot-gc-dev@openjdk.java.net" <hotspot-gc-dev@openjdk.java.net><br>
<b>Subject: </b>Re: RFR (XS) 8061467: Add UseLargePages to TestNUMAPageSize<o:p></o:p></span></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Hi all, <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Here is the webrev with all the reviewers added:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a href="http://cr.openjdk.java.net/~jcbeyler/8063110/webrev.03/">http://cr.openjdk.java.net/~jcbeyler/8063110/webrev.03/</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Let me know if I can/should do anything else for this webrev.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks for all your help,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Jc<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Mon, Aug 13, 2018 at 11:04 PM Per Liden <<a href="mailto:per.liden@oracle.com">per.liden@oracle.com</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal">Hi,<br>
<br>
On 08/13/2018 06:22 PM, JC Beyler wrote:<br>
> Hi all,<br>
> <br>
> I added Per's fix into the webrev:<br>
> <a href="http://cr.openjdk.java.net/~jcbeyler/8063110/webrev.02/" target="_blank">
http://cr.openjdk.java.net/~jcbeyler/8063110/webrev.02/</a><br>
> <br>
> (I also put you Thomas as reviewer, I was not sure Per wanted to be put <br>
> as reviewer, let me know).<br>
<br>
Sure, you can put me as reviewer.<br>
<br>
/Per<br>
<br>
> <br>
> Not sure if you wanted to wait or not to push it but at least this <br>
> version would be the version that does not run with ZGC.<br>
> <br>
> Thanks for your help,<br>
> Jc<br>
> <br>
> On Mon, Aug 13, 2018 at 5:54 AM Per Liden <<a href="mailto:per.liden@oracle.com" target="_blank">per.liden@oracle.com</a>
<br>
> <mailto:<a href="mailto:per.liden@oracle.com" target="_blank">per.liden@oracle.com</a>>> wrote:<br>
> <br>
> On 08/13/2018 11:41 AM, Thomas Schatzl wrote:<br>
> > Hi,<br>
> ><br>
> > while testing this patch before push it seems like the problem<br>
> is ZGC<br>
> > which does not fall back to using small pages (which I did not know).<br>
> ><br>
> >> [5.048s][error][gc,init] Not enough space available on the backing<br>
> > filesystem to hold the current max<br>
> >> [5.048s][error][gc,init] Java heap size (128M). Forcefully lowering<br>
> > max Java heap size to 0M (0%).<br>
> >> Error occurred during initialization of VM<br>
> >> java.lang.OutOfMemoryError: Java heap too small<br>
> ><br>
> > I will hold off pushing this before this issue has been resolved<br>
> in one<br>
> > way or the other.<br>
> <br>
> UseNUMA is enabled by default in ZGC, so it's tested frequently anyway.<br>
> I guess the easiest solution is to just not run this test when ZGC is<br>
> enabled, something like this:<br>
> <br>
> diff --git a/test/hotspot/jtreg/gc/TestNUMAPageSize.java<br>
> b/test/hotspot/jtreg/gc/TestNUMAPageSize.java<br>
> --- a/test/hotspot/jtreg/gc/TestNUMAPageSize.java<br>
> +++ b/test/hotspot/jtreg/gc/TestNUMAPageSize.java<br>
> @@ -27,7 +27,8 @@<br>
> * @summary Make sure that start up with NUMA support does not cause<br>
> problems.<br>
> * @bug 8061467<br>
> * @requires vm.opt.AggressiveOpts != true<br>
> - * @run main/othervm -Xmx128m -XX:+UseNUMA TestNUMAPageSize<br>
> + * @requires vm.gc != "Z"<br>
> + * @run main/othervm -Xmx128m -XX:+UseNUMA -XX:+UseLargePages<br>
> TestNUMAPageSize<br>
> */<br>
> <br>
> public class TestNUMAPageSize {<br>
> <br>
> <br>
> cheers,<br>
> Per<br>
> <br>
> <br>
> ><br>
> > Thanks,<br>
> > Thomas<br>
> ><br>
> > On Mon, 2018-08-13 at 10:23 +0200, Thomas Schatzl wrote:<br>
> >> Hi,<br>
> >><br>
> >> On Mon, 2018-08-13 at 09:58 +0200, Per Liden wrote:<br>
> >>> Hmm, I suspect this might fail on many Linux systems, since it<br>
> >>> might require configuring the huge page pool with enough pages.<br>
> >><br>
> >> from my understanding -XX:+UseLargePages will just give some<br>
> >> warnings<br>
> >> at startup if it can not allocate pages. It will not fail.<br>
> >><br>
> >> Assuming that the intent is to check whether when trying to use<br>
> large<br>
> >> pages (and the machine is properly configured), does not in any way<br>
> >> make the VM crash, the warnings can be ignored.<br>
> >><br>
> >> I am not aware there is a way to run tests on machines only that<br>
> have<br>
> >> the property "properly configured large pages" at this time.<br>
> >><br>
> >> Thanks,<br>
> >> Thomas<br>
> >><br>
> ><br>
> <br>
> <br>
> <br>
> -- <br>
> <br>
> Thanks,<br>
> Jc<o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><br clear="all">
<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">-- <o:p></o:p></p>
<div>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Thanks, <o:p></o:p></p>
<div>
<p class="MsoNormal">Jc<o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>