<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi<div class=""><br class=""></div><div class="">Could you please review small fix which rename class G1PrintCollectionSetClosure in g1CollectionSet.cpp.</div><div class=""><br class=""></div><div class="">While I was developing test for <a class="issue-link" data-issue-key="JDK-8209150" href="https://bugs.openjdk.java.net/browse/JDK-8209150" id="key-val" rel="4969600" style="color: rgb(59, 115, 175); text-decoration: none; cursor: pointer;">JDK-8209150</a> <span style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255); color: rgb(51, 51, 51);" class="">[TESTBUG] Add logging to verify JDK-8197901 to a different test </span></div><div class=""><span style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255);" class=""><font color="#333333" class="">I observed SEGV on <span style="caret-color: rgb(51, 51, 51);" class="">macosx</span>. Actually a lot of tests fail because of this same issue when logging is enabled.</font></span></div><div class=""><span style="orphans: 2; widows: 2; background-color: rgb(255, 255, 255); color: rgb(51, 51, 51);" class=""><br class=""></span></div><div style="orphans: 2; widows: 2;" class=""><font color="#333333" class=""><span style="caret-color: rgb(51, 51, 51); background-color: rgb(255, 255, 255);" class="">The tests fail with SEGV in </span></font></div><div style="orphans: 2; widows: 2;" class=""><font color="#333333" class=""><span style="background-color: rgb(255, 255, 255);" class=""><div class="">V [libjvm.dylib+0xa39bbf] outputStream::print_cr(char const*, ...)+0x81</div><div class="">V [libjvm.dylib+0x536e6b] G1PrintCollectionSetClosure::do_heap_region(HeapRegion*)+0x11b</div><div class="">V [libjvm.dylib+0x535864] G1CollectionSet::iterate_from(HeapRegionClosure*, unsigned int, unsigned int) const+0x54</div><div class=""><div class="">V [libjvm.dylib+0x52a2d2] G1CollectedHeap::do_collection_pause_at_safepoint(double)+0x7f2</div></div><div class=""><br class=""></div></span></font></div><div class=""><br class=""></div><div class="">because class '<span style="caret-color: rgb(51, 51, 51); color: rgb(51, 51, 51); orphans: 2; widows: 2; background-color: rgb(255, 255, 255);" class="">G1PrintCollectionSetClosure'</span> is used from</div><div class=""><a href="http://hg.openjdk.java.net/jdk/jdk/file/d96e6839e83d/src/hotspot/share/gc/g1/g1CollectionSet.cpp#l331" class="">http://hg.openjdk.java.net/jdk/jdk/file/d96e6839e83d/src/hotspot/share/gc/g1/g1CollectionSet.cpp#l331</a></div><div class="">instead of </div><div class=""><a href="http://hg.openjdk.java.net/jdk/jdk/file/d96e6839e83d/src/hotspot/share/gc/g1/g1CollectedHeap.cpp#l2751" class="">http://hg.openjdk.java.net/jdk/jdk/file/d96e6839e83d/src/hotspot/share/gc/g1/g1CollectedHeap.cpp#l2751</a></div><div class="">so it tries to do completely wrong thing... </div><div class=""><br class=""></div><div class="">I think it would be enough just to rename one of classes to avoid confusion.</div><div class=""><br class=""></div><div class="">webrev: <a href="http://cr.openjdk.java.net/~lmesnik/8209758/webrev.00/" class="">http://cr.openjdk.java.net/~lmesnik/8209758/webrev.00/</a></div><div class="">bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8209758" class="">https://bugs.openjdk.java.net/browse/JDK-8209758</a></div><div class=""><span style="caret-color: rgb(51, 51, 51); color: rgb(51, 51, 51); orphans: 2; widows: 2; background-color: rgb(255, 255, 255);" class="">I run gc & serviceability tests with enabled logging to verify that they work fine now.</span></div><div class=""><br class=""></div><div class="">The separate regression test which fails without any additional options will be integrated as fix for <a href="https://bugs.openjdk.java.net/browse/JDK-8209150" class="">https://bugs.openjdk.java.net/browse/JDK-8209150</a></div><div class="">Leonid</div><div class=""><header class="aui-page-header" style="width: auto; background-color: rgb(255, 255, 255); padding: 20px 20px 9px; color: rgb(51, 51, 51); font-family: Arial, sans-serif; font-size: 14px; font-variant-ligatures: normal; orphans: 2; widows: 2; background-position: initial initial; background-repeat: initial initial;"><div class="aui-page-header-inner" style="margin: 0px; padding: 0px; border-spacing: 0px; box-sizing: border-box; display: table; table-layout: auto; width: 1812px;"><div class="aui-page-header-main" style="margin: 0px; padding: 0px 0px 0px 10px; box-sizing: border-box; display: table-cell; vertical-align: middle;"><div class=""><br class=""></div><h1 id="summary-val" class="editable-field inactive" title="Click to edit" style="margin: 0px 0px 0px -5px; padding: 2px 30px 2px 5px; font-size: 24px; font-weight: normal; line-height: 1.25; box-sizing: border-box; transition: box-shadow 150ms ease-in 0ms; border-top-left-radius: 2.01px; border-top-right-radius: 2.01px; border-bottom-right-radius: 2.01px; border-bottom-left-radius: 2.01px; cursor: text; display: inline-block; max-width: 100%; box-shadow: transparent 0px 0px 0px 0px; position: relative; vertical-align: top; word-break: break-word; transform: translateZ(1px); z-index: 1;"><span class="aui-iconfont-edit overlay-icon aui-icon-small aui-icon" style="border-style: none none none solid; border-left-width: 1px; border-left-color: rgb(204, 204, 204); display: inline-block; height: auto; margin: 0px; padding: 0px; text-indent: -999em; vertical-align: text-top; width: 24px; line-height: 0; position: absolute; box-sizing: border-box; opacity: 0; background-color: rgb(240, 240, 240); bottom: 0px; right: 0px; top: 0px; z-index: -1; color: rgb(112, 112, 112); cursor: pointer; background-position: 4px 4px; background-repeat: no-repeat no-repeat;"></span></h1></div><div class="aui-page-header-actions" style="margin: 0px; padding: 0px 0px 0px 20px; box-sizing: border-box; display: table-cell; text-align: right; vertical-align: middle; width: 13em;"><br class=""><div id="issue-header-pager" style="margin: 0px; padding: 0px;" class=""></div></div></div></header></div></body></html>