<div>Hi all,</div><div><br></div><div>Thanks, Stefan! I have added a test for the hsperf counter. The test is based on <font face="sans-serif"><span style="font-size:12.8px">test/hotspot/jtreg/gc/TestGenerationPerfCounter.java. </span></font></div><div>New webrev:</div><a href="http://cr.openjdk.java.net/~jcbeyler/8210192/webrev.01/">http://cr.openjdk.java.net/~jcbeyler/8210192/webrev.01/</a><div><br></div><div>I have run some basic tests with "make run-test", and those related to test/hotspot/jtreg/gc/testlibrary/PerfCounter.java are still passing.</div><div><br></div><div>Thanks,</div><div>Man</div><div><br>On Friday, August 31, 2018, Stefan Johansson <<a href="mailto:stefan.johansson@oracle.com">stefan.johansson@oracle.com</a>> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">On 2018-08-31 02:07, Man Cao wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Thanks for the review!<br>
Should we wait for another "looks good" before JC can submit it?<br>
<br>
</blockquote>
Yes, we should wait to get a second review.<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Since the testing infrastructure did not catch this change, should we add a test for this hsperf counter?<br>
</blockquote>
That would probably be good, please look at the other counter tests and create something similar to that. Once you have the test I can apply the patch and run it through our test system to make sure it passes on all platforms.<br>
<br>
Thanks,<br>
Stefan<br>
<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
PS: I found a better command to test for its value:<br>
$ jstat -J-Djstat.showUnsupported=true -snap file:///$(pwd)/test.hsperf | grep <a href="http://sun.gc.policy.name" target="_blank">sun.gc.policy.name</a> <<a href="http://sun.gc.policy.name" target="_blank">http://sun.gc.policy.name</a>><br>
<br>
-Man<br>
<br>
<br>
On Thu, Aug 30, 2018 at 1:52 AM Stefan Johansson <<a href="mailto:stefan.johansson@oracle.com" target="_blank">stefan.johansson@oracle.com</a> <mailto:<a href="mailto:stefan.johansson@oracle.com" target="_blank">stefan.johansson@<wbr>oracle.com</a>>> wrote:<br>
<br>
<br>
<br>
On 2018-08-30 02:29, Man Cao wrote:<br>
> Hi all,<br>
><br>
> I noticed a possible slight naming bug for the HSPerf<br>
> counter "<a href="http://sun.gc.policy.name" target="_blank">sun.gc.policy.name</a> <<a href="http://sun.gc.policy.name" target="_blank">http://sun.gc.policy.name</a>><br>
<<a href="http://sun.gc.policy.name" target="_blank">http://sun.gc.policy.name</a>>", introduced by<br>
> <a href="http://hg.openjdk.java.net/jdk/jdk/rev/170c7b36aea6" target="_blank">http://hg.openjdk.java.net/jdk<wbr>/jdk/rev/170c7b36aea6</a>.<br>
><br>
> Basically instead of "ParNew:CMS", the counter's value is now<br>
"ParNew::CMS".<br>
><br>
> Here is a fix for the bug, could someone review it?<br>
><br>
> Webrev: <a href="http://cr.openjdk.java.net/~jcbeyler/8210192/webrev.00/" target="_blank">http://cr.openjdk.java.net/~jc<wbr>beyler/8210192/webrev.00/</a><br>
<<a href="http://cr.openjdk.java.net/%7Ejcbeyler/8210192/webrev.00/" target="_blank">http://cr.openjdk.java.net/%7<wbr>Ejcbeyler/8210192/webrev.00/</a>><br>
> <<a href="http://cr.openjdk.java.net/%7Ejcbeyler/8210192/webrev.00/" target="_blank">http://cr.openjdk.java.net/%7<wbr>Ejcbeyler/8210192/webrev.00/</a>><br>
> Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8210192" target="_blank">https://bugs.openjdk.java.net/<wbr>browse/JDK-8210192</a><br>
<br>
Looks good and since the bug hasn't shown up in our testing I don't<br>
think fixing it back should be a problem testing wise.<br>
<br>
Thanks,<br>
StefanJ<br>
<br>
><br>
> PS: Thanks JC for creating the bug and hosting the webrev!<br>
><br>
> Thanks!<br>
> Man<br>
<br>
</blockquote>
</blockquote></div><br><br>-- <br><div dir="ltr">-Man</div><br>