<div dir="ltr">Thanks both,<div><br></div><div>I updated the webrev, sent it on the submit repo, it passed, and then pushed it.</div><div><br></div><div>Have a great weekend,</div><div>Jc</div><div><br></div></div><br><div class="gmail_quote"><div dir="ltr">On Fri, Sep 14, 2018 at 12:38 AM Stefan Johansson <<a href="mailto:stefan.johansson@oracle.com">stefan.johansson@oracle.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
<br>
On 2018-09-14 02:41, Kim Barrett wrote:<br>
>> On Sep 13, 2018, at 8:01 PM, Man Cao <<a href="mailto:manc@google.com" target="_blank">manc@google.com</a>> wrote:<br>
>><br>
>> Hi all,<br>
>><br>
>> Could anyone review this logging change for oopstorage?<br>
>> Webrev: <a href="http://cr.openjdk.java.net/~jcbeyler/8210724/webrev.00/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~jcbeyler/8210724/webrev.00/</a><br>
>> Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8210724" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8210724</a><br>
>><br>
>> This is similar to the webrev I previously sent for <a href="https://bugs.openjdk.java.net/browse/JDK-8210562" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8210562</a>. Kim mentioned it might be reasonable to improve the logging in oopStorage.cpp. We discussed and decided to create a separate issue for improving the logging.<br>
>><br>
>> The patch changes the logging level for [oopstorage,ref] to trace, and consistently uses debug level for [oopstorage,blocks] and unusual events, and uses log_info() for printing statistics. I think this would make the logging for oopstorage more user-friendly.<br>
>><br>
>> Below is comparison of lines of messages:<br>
>> $ java -Xlog:oopstorage*=<level> -Xms500m -Xmx500m -jar dacapo-9.12-bach.jar tradesoap<br>
>> info | debug | trace<br>
>> without patch: 107934 | 112990 | 112701<br>
>> with patch: 1694 | 5247 | 112241<br>
>><br>
>> -Man<br>
> <br>
> Looks good.<br>
><br>
<br>
Looks good to me too,<br>
Stefan<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>