<div dir="ltr"><div dir="ltr"><div dir="ltr">Hi Paul,<div><br></div><div>The biggest thing I saw in this RFR was that the flags for the test:</div><div><a href="http://cr.openjdk.java.net/~phh/8195115/webrev.05/test/gc/g1/mixedgc/TestOldGenCollectionUsage.java.html">http://cr.openjdk.java.net/~phh/8195115/webrev.05/test/gc/g1/mixedgc/TestOldGenCollectionUsage.java.html</a><br></div><div><br></div><div>were changed it seems:</div><div>- the @requires are different for the backport (you accept null for JDK8 for GC and also removed the @requires vm.opt.MaxGCPauseMillis == "null")</div><div>- the @run flags are different (-Xms/Xmx are 14m for the backport; they were 12 originally; there is a comment below in the backport saying this requires normally 12m though you ask for 14 in the @run)</div><div><br></div><div>What are the reasons for these differences?</div><div><br></div><div>Apart from that, the backport seemed ok but I'm not that well versed in the GC changes :)</div><div>Jc</div></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, Oct 11, 2018 at 5:04 PM Hohensee, Paul <<a href="mailto:hohensee@amazon.com">hohensee@amazon.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="m_-4417657402513354404WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt">Please review a backport to jdk8u.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8195115" target="_blank">
https://bugs.openjdk.java.net/browse/JDK-8195115</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Webrev: <a href="http://cr.openjdk.java.net/~phh/8195115/webrev.05/" target="_blank">
http://cr.openjdk.java.net/~phh/8195115/webrev.05/</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">JDK11 patch: <a href="http://hg.openjdk.java.net/jdk/jdk/rev/5d3c5af82654" target="_blank">
http://hg.openjdk.java.net/jdk/jdk/rev/5d3c5af82654</a><u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">The backport is slightly different from the JDK11 patch due to G1 refactoring, hence my request for new review. I’ll ask for jdk8u approval once the backport is reviewed.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">I backported two jtreg tests from JDK11, which pass. Also, all the hotspot gc jtreg tests pass as well as they do for jdk8u-dev.<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">There was a CSR involved, <a href="https://bugs.openjdk.java.net/browse/JDK-8196719" target="_blank">
https://bugs.openjdk.java.net/browse/JDK-8196719</a>. Does that have to be re-approved for jdk8u as well, and if so, what’s the process?<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Thanks,<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt">Paul<u></u><u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><u></u> <u></u></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt"><u></u> <u></u></span></p>
</div>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>