<html><head><meta http-equiv="Content-Type" content="text/html; charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">Hi JC,<div class=""><br class=""></div><div class="">thanks for your review!</div><div class=""><br class=""></div><div class="">Cheers,</div><div class="">-- Igor<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Oct 16, 2018, at 12:51 PM, JC Beyler <<a href="mailto:jcbeyler@google.com" class="">jcbeyler@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class=""><div dir="ltr" class="">Hi Igor,<br class=""><div class=""><br class=""></div><div class="">The change looks good to me, I compared old/new, the port looks good.</div><div class=""><br class=""></div><div class="">For the reviewers, here is the original test code:</div><div class=""><a href="http://hg.openjdk.java.net/jdk/jdk/file/2e928420389d/src/hotspot/share/memory/virtualspace.cpp#l1071" class="">http://hg.openjdk.java.net/jdk/jdk/file/2e928420389d/src/hotspot/share/memory/virtualspace.cpp#l1071</a><br class=""></div><div class=""><br class=""></div><div class="">Thanks,</div><div class="">Jc</div></div></div></div></div><br class=""><div class="gmail_quote"><div dir="ltr" class="">On Tue, Oct 16, 2018 at 9:06 AM Igor Ignatyev <<a href="mailto:igor.ignatyev@oracle.com" class="">igor.ignatyev@oracle.com</a>> wrote:<br class=""></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><a href="http://cr.openjdk.java.net/~iignatyev//8171097/webrev.00/index.html" rel="noreferrer" target="_blank" class="">http://cr.openjdk.java.net/~iignatyev//8171097/webrev.00/index.html</a><br class="">
> 188 lines changed: 187 ins; 1 del; 0 mod; <br class="">
<br class="">
Hi all,<br class="">
<br class="">
could you please review this small (and hopefully trivial) patch which converts internal TestReservedSpace_test to gtest? <br class="">
since the old test is still used by WhiteBox::runMemoryUnitTests, the old code hasn't been removed. it will be removed later when all 4 tests used by runMemoryUnitTests are converted.<br class="">
<br class="">
webrev: <a href="http://cr.openjdk.java.net/~iignatyev//8171097/webrev.00/index.html" rel="noreferrer" target="_blank" class="">http://cr.openjdk.java.net/~iignatyev//8171097/webrev.00/index.html</a><br class="">
JBS: <a href="https://bugs.openjdk.java.net/browse/JDK-8171097" rel="noreferrer" target="_blank" class="">https://bugs.openjdk.java.net/browse/JDK-8171097</a><br class="">
testing:<br class="">
- converted tests on linux-x64, windows-x64, macosx-x64, solaris-sparcv9 in product and fastdebug variants <br class="">
- build w/ precompiled-headers enabled and disabled<br class="">
<br class="">
PS the patch has been originally created by Kirill Zh, but hasn't been sent out for official review<br class="">
<br class="">
Thanks,<br class="">
-- Igor </blockquote></div><br clear="all" class=""><div class=""><br class=""></div>-- <br class=""><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr" class=""><div class=""><br class=""></div>Thanks,<div class="">Jc</div></div></div>
</div></blockquote></div><br class=""></div></body></html>