<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Thomas,<br>
<br>
<div class="moz-cite-prefix">On 10/2/18 8:57 AM, Thomas Schatzl
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:10549c6a3761fe3a2ec76a1dc3b001fa708520f6.camel@oracle.com">
<pre wrap="">Hi all,
allow me to provide a fix for the oldest g1-specific open issue on
the bug tracker (from 2006 :)): resize the heap (eg. uncommit)
according to existing sizing policies at remark time.
It does exactly what the subject of the CR says.
The feature is enabled by default - I did not see any reason to disable
it as the functionality seems to actually be what would be expected of
the concurrent cycle (as it mirrors the functionality of a full gc).
Needs the change for JDK-8071913 currently out for review applied to
work (i.e. not crash after uncommit).
The current work for "JDK-8204089: Timely Reducing Unused Committed
Memory" also depends on this change.
CR:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-6490394">https://bugs.openjdk.java.net/browse/JDK-6490394</a>
Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~tschatzl/6490394/webrev/">http://cr.openjdk.java.net/~tschatzl/6490394/webrev/</a></pre>
</blockquote>
Looks good.<br>
Just minor nits so okay going with current webrev. And I don't need
extra webrev if you accept it.<br>
<br>
-----------------------------------------<br>
src/hotspot/share/gc/g1/g1CollectedHeap.cpp<br>
<pre><span class="new">4399 assert(r->rem_set()->is_empty(), "Remembered sets should be empty.");</span></pre>
<pre><span class="new">4404 assert(r->rem_set()->is_empty(), "Remembered sets should be empty.");</span>
</pre>
- Can we differentiate newly added 2 same assert? This can be
'Remembered sets should be empty, if the region is empty'.<br>
<br>
<br>
-----------------------------------------<br>
test/hotspot/jtreg/gc/g1/humongousObjects/objectGraphTest/TestObjectGraphAfterGC.java<br>
- Copyright update<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
<blockquote type="cite"
cite="mid:10549c6a3761fe3a2ec76a1dc3b001fa708520f6.camel@oracle.com">
<pre wrap="">
Testing:
hs-tier1-5, jdk-tier1-3, perf testing ongoing but not expecting a
difference
Thanks,
Thomas
</pre>
</blockquote>
<br>
</body>
</html>