<div><div dir="auto">Looks good to me.</div></div><div dir="auto"><br></div><div dir="auto">Cheers, Thomas</div><div dir="auto"><br></div><div><br><div class="gmail_quote"><div dir="ltr">On Wed 16. Jan 2019 at 22:00, Aleksey Shipilev <<a href="mailto:shade@redhat.com">shade@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi,<br>
<br>
On 1/16/19 9:34 PM, Thomas Stüfe wrote:<br>
> looks good.<br>
<br>
Thanks!<br>
<br>
> In your test you could set the initial metaspace size to a small size too for added effect, this<br>
> triggers a lot of resizing early on (eg -XX:MetaspaceSize=1m).<br>
<br>
Right. I was trying to achieve the same by setting Initial*, but MetaspaceSize is sure better.<br>
<br>
> nit: EpsilonHeap::print_metaspace_info(): I assume this cannot be called before metaspace is set up.<br>
> Still, would prefer checking for reserved=0 before printing the percentages.<br>
<br>
Nice catch. Checked for zero in both heap and metaspace cases. Also turned both methods private, so<br>
we control when they are called from within.<br>
<br>
New webrev:<br>
<a href="http://cr.openjdk.java.net/~shade/8217014/webrev.02/" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~shade/8217014/webrev.02/</a><br>
<br>
Thanks,<br>
-Aleksey<br>
<br>
</blockquote></div></div>