<div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div>After offline discussion with Jiangli, we think it is better to just remove this comment block.</div><div>The reason is that full GCs due to metaspace expansion will not take the code path to execute AdaptiveSizePolicy::check_gc_overhead_limit(), because of the check for AdaptiveSizePolicy::should_update_promo_stats().</div><div><br></div><div>New webrev: <a href="https://cr.openjdk.java.net/~manc/8212206/webrev.05/">https://cr.openjdk.java.net/~manc/8212206/webrev.05/</a><br></div></div><div dir="ltr"><br clear="all"><div><div dir="ltr" class="gmail_signature"><div dir="ltr">-Man</div></div></div><br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Mar 4, 2019 at 2:41 PM Man Cao <<a href="mailto:manc@google.com">manc@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">Thanks for taking a look, Jiangli. I renamed "permanent gen" to "metaspace".</div><div>I double checked that currently full GCs due to metaspace expansion will not affect the calculation of GC overhead .</div><div dir="ltr"><br></div><div dir="ltr"><div>New webrev: <a href="https://cr.openjdk.java.net/~manc/8212206/webrev.04/" target="_blank">https://cr.openjdk.java.net/~manc/8212206/webrev.04/</a></div><div><br></div><div><div><div dir="ltr" class="gmail-m_-1021686102468943626gmail_signature"><div dir="ltr">-Man</div></div></div><br></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Sun, Mar 3, 2019 at 11:48 AM Jiangli Zhou <<a href="mailto:jianglizhou@google.com" target="_blank">jianglizhou@google.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div dir="ltr"><div dir="ltr">Hi Man,<div><br></div><div>As both Thomas and Per seemed to be okay with the refactoring, you probably had sufficient approval already. </div><div><br></div><div>The following comment in adaptiveSizePolicy.cpp seems to be outdated. The comment predates the PermGen removal. It's probably a good idea to also cleanup the comment as part of your refactoring change.</div><div><span style="color:blue"><br></span></div><div><pre style="color:rgb(0,0,0)"><span class="gmail-m_-1021686102468943626gmail-m_-6168085959059968675gmail-changed" style="color:blue"> 281 // Note that the gc time limit test only works for the collections</span>
<span class="gmail-m_-1021686102468943626gmail-m_-6168085959059968675gmail-changed" style="color:blue"> 282 // of the young gen + tenured gen and not for collections of the</span>
<span class="gmail-m_-1021686102468943626gmail-m_-6168085959059968675gmail-changed" style="color:blue"> 283 // permanent gen. That is because the calculation of the space</span>
<span class="gmail-m_-1021686102468943626gmail-m_-6168085959059968675gmail-changed" style="color:blue"> 284 // freed by the collection is the free space in the young gen +</span>
<span class="gmail-m_-1021686102468943626gmail-m_-6168085959059968675gmail-changed" style="color:blue"> 285 // tenured gen.</span></pre><pre style="color:rgb(0,0,0)">Thanks and regards,</pre><pre style="color:rgb(0,0,0)">Jiangli</pre></div></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
</blockquote></div>
</blockquote></div>
</blockquote></div></div>
</blockquote></div>
</blockquote></div></div></div></div>