<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<tt>Hi Per,</tt><br>
<pre><span class="new"> 723 manageable(size_t, SoftMaxHeapSize, 0, \</span>
<span class="new"> 724 "Soft limit for maximum heap size (in bytes)") \</span>
<span class="new"> 725 constraint(SoftMaxHeapSizeConstraintFunc,AfterMemoryInit) \</span>
<span class="new"> 726 \
Seems like the indentation is a bit off here. Otherwise, this looks good. Don't need another webrev for the indentation fix.
Thanks,
/Erik
</span></pre>
<div class="moz-cite-prefix">On 2019-04-10 14:06, Per Liden wrote:<br>
</div>
<blockquote type="cite"
cite="mid:1d67bfb4-a28a-34f1-93d5-97f8433024fe@oracle.com">Introduce
a manageable SoftMaxHeapSize flag. When set, the GC should strive
to not grow heap size beyond the specified size. But as the flag
name suggests, this is a soft limit. In other words, the GC is
allowed to grow the heap size beyond SoftMaxHeapSize if needed.
<br>
<br>
There are a few different use cases where this flag could be
useful. For example, when you want to keep the heap footprint
down, while retaining the capability to deal with a temporary
increase in heap space requirement. Or when you want to play it
safe, with lots of margin, to increase confidence that you will
not run into an allocation stall because of an unforeseen increase
in allocation rate.
<br>
<br>
The SoftMaxHeapSize should not be allowed to be set to a value
smaller than min heap size (-Xms) or greater than max heap size
(-Xmx). When not set on the command-line, this flag should default
to the max heap size.
<br>
<br>
Bug: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8222145">https://bugs.openjdk.java.net/browse/JDK-8222145</a>
<br>
CSR: <a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8222181">https://bugs.openjdk.java.net/browse/JDK-8222181</a>
<br>
Webrev: <a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~pliden/8222145/webrev.1">http://cr.openjdk.java.net/~pliden/8222145/webrev.1</a>
<br>
<br>
/Per
<br>
</blockquote>
<br>
</body>
</html>