<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <p>Hi Ao Qi,<br>
      <br>
      1) Style does not match<br>
         f(StringTableRoots,        "StringTable Roots(ms):")          \<br>
      +  f(Resolved_Method_TableRoots, "Resolved_Method_Table
      Roots(ms):")          <br>
      <br>
      'Resolved_Method_TableRoots' => ResolvedMethodTableRoots<br>
      <br>
      <br>
      2) This is a sub-phase, you also need corresponding phases, For
      example:<br>
    </p>
    <pre style="background-color:#ffffff;color:#000000;font-family:'DejaVu Sans Mono';font-size:10.6pt;">f(scan_jfr_weak_roots,                            <span style="color:#008000;font-weight:bold;">"    S: JFR Weak Roots"</span>)            \
f(scan_jni_weak_roots,                            <span style="color:#008000;font-weight:bold;">"    S: JNI Weak Roots"</span>)            \
f(scan_stringtable_roots,                         <span style="color:#008000;font-weight:bold;">"    S: String Table Roots"</span>)        \
<font color="#ff0000">f(scan_resolved_method_table_roots,               "    S: Resolved Table Roots")      \</font>
f(scan_vm_weak_roots,                             <span style="color:#008000;font-weight:bold;">"    S: VM Weak Roots"</span>)             \</pre>
    <p>Thanks,</p>
    <p>-Zhengyu<br>
    </p>
    <p>On 4/11/19 7:07 AM, Ao Qi wrote:<br>
    </p>
    <blockquote type="cite"
cite="mid:CALjzQn7_ZUPyAseUvk0vNeeKAe+-6Fy6FbRjOGX8SN1nkk32EQ@mail.gmail.com">
      <pre class="moz-quote-pre" wrap="">Hi,

Bugs:
<a class="moz-txt-link-freetext" href="https://bugs.openjdk.java.net/browse/JDK-8222333">https://bugs.openjdk.java.net/browse/JDK-8222333</a>

Webrev:
<a class="moz-txt-link-freetext" href="http://cr.openjdk.java.net/~aoqi/8222333/webrev.00/">http://cr.openjdk.java.net/~aoqi/8222333/webrev.00/</a>

fastdebug build is broken after JDK-8221393. It seems that
phase_mapping[] doesn't match enum Phase in WeakProcessorPhases
anymore. Is this fix ok? I am not familiar with shenandoah.
linux-x86_64-server-release hotspot:tier1 tested.

Thanks,
Ao Qi
</pre>
    </blockquote>
  </body>
</html>