<div dir="ltr"><div dir="ltr">Looks good.</div><div dir="ltr"><br clear="all"><div><div dir="ltr" class="gmail_signature" data-smartmail="gmail_signature"><div dir="ltr">-Man</div></div></div><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr"><strong>From: </strong><span dir="ltr"><<a href="mailto:sangheon.kim@oracle.com">sangheon.kim@oracle.com</a>></span><br><strong>Date: </strong>Tue, Apr 30, 2019 at 1:41 PM<br><strong>To: </strong>Thomas Schatzl<br><strong>Cc: </strong> <<a href="mailto:hotspot-gc-dev@openjdk.java.net">hotspot-gc-dev@openjdk.java.net</a>><br><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Thomas,<br>
<br>
On 4/26/19 1:29 AM, Thomas Schatzl wrote:<br>
> Hi all,<br>
><br>
>    can I have reviews for this change that fixes the<br>
> G1RemSet::*oops_into_collection_set_do methods to correspond to the<br>
> naming of the main method scan_rem_set again.<br>
><br>
> CR:<br>
> <a href="https://bugs.openjdk.java.net/browse/JDK-8223018" rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8223018</a><br>
> Webrev:<br>
> <a href="http://cr.openjdk.java.net/~tschatzl/8223018/webrev" rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~tschatzl/8223018/webrev</a><br>
Looks good.<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
> Testing:<br>
> local compilation<br>
><br>
> Thanks,<br>
>    Thomas<br>
><br>
<br>
</blockquote></div></div>