<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
Hi Man,<br>
<br>
<div class="moz-cite-prefix">On 5/3/19 1:18 PM, Man Cao wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CA+w6HxYDbswrm=-gQ2JK7SfDQ8O3HsekReKLyOEer++BPvTEsg@mail.gmail.com">
<div dir="ltr">Hi Sangheon,
<div><br>
</div>
<div>The change looks good to me. I'm not an official "Reviewer"
though.</div>
</div>
</blockquote>
Thanks for your review.<br>
Thomas S. suggested to rename to
'assert_used_and_recalculate_used_equal()' before pushing. No more
webrev. :)<br>
Hope you are okay with that.<br>
<br>
Thanks,<br>
Sangheon<br>
<br>
<br>
<blockquote type="cite"
cite="mid:CA+w6HxYDbswrm=-gQ2JK7SfDQ8O3HsekReKLyOEer++BPvTEsg@mail.gmail.com">
<div dir="ltr">
<div><br clear="all">
<div>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">-Man</div>
</div>
</div>
<br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr"><strong>From: </strong><span
dir="ltr"><<a href="mailto:sangheon.kim@oracle.com"
moz-do-not-send="true">sangheon.kim@oracle.com</a>></span><br>
<strong>Date: </strong>Tue, Apr 30, 2019 at 1:54 PM<br>
<strong>To: </strong>hotspot-gc-dev<br>
<br>
</div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi
all,<br>
<br>
Can I have some reviews that replace assert(used() == <br>
recalculated_used()) with better message?<br>
Those assert messages are not much helpful as it doesn't
include any <br>
actual values on it so I'm suggesting to include actual values
of each <br>
and then replace as a macro.<br>
<br>
CR: <a
href="https://bugs.openjdk.java.net/browse/JDK-8221509"
rel="noreferrer" target="_blank" moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8221509</a><br>
webrev: <a
href="http://cr.openjdk.java.net/%7Esangheki/8221509/webrev.0/"
rel="noreferrer" target="_blank" moz-do-not-send="true">http://cr.openjdk.java.net/~sangheki/8221509/webrev.0/</a><br>
testing: local build<br>
<br>
Thanks,<br>
Sangheon<br>
</blockquote>
</div>
</blockquote>
<br>
</body>
</html>