<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap:break-word;line-break:after-white-space"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">BTW, I got the results back from jdk/submit and it failed to build on three platforms. Is there a way to find out what the issue is? All I know is “return value: 2â€.</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">Thanks,</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">Tony</div> <br> <div id="bloop_sign_1557331599676363008" class="bloop_sign"><div><br></div><div><div>—————</div><div>Tony Printezis | @TonyPrintezis | <a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a></div></div><div><br></div></div> <br><p class="airmail_on">On May 8, 2019 at 10:20:18 AM, Tony Printezis (<a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div style="word-wrap:break-word;line-break:after-white-space"><div></div><div>
<title></title>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
Any chance of someone taking a look at this?</div>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<br></div>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<a href="http://cr.openjdk.java.net/~tonyp/8223575/webrev.0/">http://cr.openjdk.java.net/~tonyp/8223575/webrev.0/</a></div>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<br></div>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
As I said on the JIRA, users can be confused when they metaspace
capacity shows as over 1G even though they asked for 128M. Breaking
down the spaces, when coops are enabled, can address this confusion
(and having the actual occupancy of each space separately is also a
lot more informative and avoids guesswork). The output looks like
this when coops are enabled:</div>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<br></div>
<div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo">
<span style="font-variant-ligatures:no-common-ligatures">[10.090s][info][gc,metaspace
  ] GC(8) Metaspace: 2130K->2130K(1056768K)
ClassMetadata: 1906K->1906K(8192K) ClassSpace:
223K->223K(1048576K)</span></p>
</div>
<div><br></div>
and like this (i.e., what it was before the change) when coops are
not enabled:
<div><br></div>
<div>
<p style="margin:0px;font-stretch:normal;font-size:11px;line-height:normal;font-family:Menlo">
<span style="font-variant-ligatures:no-common-ligatures">[25.767s][info][gc,metaspace
  ] GC(28) Metaspace:
8107K->8107K(10240K)</span></p>
</div>
<div><br></div>
<div>A couple of notes on the changes:</div>
<div><br></div>
<div>- I’m open to different suggestions for what to call
ClassMetadata and ClassSpace. :-)</div>
<div>- I didn’t know where to put the HEAP_CHANGE_FORMAT and
HEAP_CHANGE_FORMAT_ARGS macros, so that they can be easily shared,
and I ended up putting them in heap.hpp. Let me know if there’s a
better place for them.</div>
<div><br></div>
<div>Tony</div>
<div><br>
<div id="bloop_sign_1557324722471365888" class="bloop_sign">
<div><br></div>
<div>
<div>—————</div>
<div>Tony Printezis | @TonyPrintezis | <a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a></div>
</div>
<div><br></div>
</div>
</div>
</div></div></span></blockquote></body></html>