<html><head><style>body{font-family:Helvetica,Arial;font-size:13px}</style></head><body style="word-wrap:break-word;line-break:after-white-space"><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">Thanks for taking a look Stefan! Trying again…</div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto"><br></div><div id="bloop_customfont" style="font-family:Helvetica,Arial;font-size:13px;color:rgba(0,0,0,1.0);margin:0px;line-height:auto">Tony</div> <br> <div id="bloop_sign_1557345636183206912" class="bloop_sign"><div><br></div><div><div>—————</div><div>Tony Printezis | @TonyPrintezis | <a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a></div></div><div><br></div></div> <br><p class="airmail_on">On May 8, 2019 at 2:59:01 PM, Stefan Karlsson (<a href="mailto:stefan.karlsson@oracle.com">stefan.karlsson@oracle.com</a>) wrote:</p> <blockquote type="cite" class="clean_bq"><span><div><div></div><div>Hi Tony,
<br>
<br>On 2019-05-08 18:08, Tony Printezis wrote:
<br>> BTW, I got the results back from jdk/submit and it failed to build on
<br>> three platforms. Is there a way to find out what the issue is? All I
<br>> know is “return value: 2”.
<br>
<br>I don't know of a way for external contributors to see the logs from the
<br>submit repo builds.
<br>
<br>It seems like your failure happened because of a mismatch between the
<br>changeset your patch is based on and Oracle's closed build bits. I think
<br>a rebase will fix it.
<br>
<br>StefanK
<br>
<br>>
<br>> Thanks,
<br>>
<br>> Tony
<br>>
<br>>
<br>> —————
<br>> Tony Printezis | @TonyPrintezis | <a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a>
<br>> <mailto:<a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a>>
<br>>
<br>>
<br>> On May 8, 2019 at 10:20:18 AM, Tony Printezis (<a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a>
<br>> <mailto:<a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a>>) wrote:
<br>>
<br>>> Any chance of someone taking a look at this?
<br>>>
<br>>> <a href="http://cr.openjdk.java.net/~tonyp/8223575/webrev.0/">http://cr.openjdk.java.net/~tonyp/8223575/webrev.0/</a>
<br>>>
<br>>> As I said on the JIRA, users can be confused when they metaspace
<br>>> capacity shows as over 1G even though they asked for 128M. Breaking
<br>>> down the spaces, when coops are enabled, can address this confusion
<br>>> (and having the actual occupancy of each space separately is also a
<br>>> lot more informative and avoids guesswork). The output looks like
<br>>> this when coops are enabled:
<br>>>
<br>>> [10.090s][info][gc,metaspace ] GC(8) Metaspace:
<br>>> 2130K->2130K(1056768K) ClassMetadata: 1906K->1906K(8192K) ClassSpace:
<br>>> 223K->223K(1048576K)
<br>>>
<br>>>
<br>>> and like this (i.e., what it was before the change) when coops are
<br>>> not enabled:
<br>>>
<br>>> [25.767s][info][gc,metaspace ] GC(28) Metaspace: 8107K->8107K(10240K)
<br>>>
<br>>>
<br>>> A couple of notes on the changes:
<br>>>
<br>>> - I’m open to different suggestions for what to call ClassMetadata
<br>>> and ClassSpace. :-)
<br>>> - I didn’t know where to put the HEAP_CHANGE_FORMAT and
<br>>> HEAP_CHANGE_FORMAT_ARGS macros, so that they can be easily shared,
<br>>> and I ended up putting them in heap.hpp. Let me know if there’s a
<br>>> better place for them.
<br>>>
<br>>> Tony
<br>>>
<br>>>
<br>>> —————
<br>>> Tony Printezis | @TonyPrintezis | <a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a>
<br>>> <mailto:<a href="mailto:tprintezis@twitter.com">tprintezis@twitter.com</a>>
<br>>>
<br>
<br></div></div></span></blockquote></body></html>