<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:\5B8B\4F53;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@\5B8B\4F53";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:72.0pt 90.0pt 72.0pt 90.0pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> After this patch was applied (since jdk8u212 and jdk-11.0.3, to be specific), we started to get test failures with jtreg. The failed test case was jdk8u/hotspot/test/gc/metaspace/TestCapacityUntilGCWrapAround.java.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> It always fails on windows-32bit platform, and fails on linux-32bit if -XX:MaxMetaspaceSize is set.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> The failure message was:<o:p></o:p></p>
<p class="MsoNormal">java.lang.IllegalStateException: WB_IncMetaspaceCapacityUntilGC: could not increase capacity until GC due to contention with another thread<o:p></o:p></p>
<p class="MsoNormal"> at sun.hotspot.WhiteBox.incMetaspaceCapacityUntilGC(Native Method)<o:p></o:p></p>
<p class="MsoNormal"> at TestCapacityUntilGCWrapAround.main(TestCapacityUntilGCWrapAround.java:51)<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> I checked the code, and found that MetaspaceGC::inc_capacity_until_GC was passed a value of 4G-page_size-1, which caused addition overflow when computing new_value, and new_value always set to "align_size_down(max_uintx, Metaspace::commit_alignment())".
So when MaxMetaspaceSize defaults to or is set to a value less than it, the function will return false to WB_IncMetaspaceCapacityUntilGC, which will then throw an Exception, causing the test failure.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"> On win-32 platform, the default value of MaxMetaspaceSize is 4G - allocation_granularity, which is 4G - 64K (according to
<a href="https://devblogs.microsoft.com/oldnewthing/20031008-00/?p=42223">https://devblogs.microsoft.com/oldnewthing/20031008-00/?p=42223</a>), this is very likely to be less than "new_value" and cause test failure.<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"> Do you have any idea how to fix this?<o:p></o:p></p>
<p class="MsoNormal"> <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</body>
</html>