<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="#0563C1" vlink="#954F72">
<div class="WordSection1">
<p class="MsoNormal">Hi,<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Requesting review for,<o:p></o:p></p>
<p class="MsoNormal">CR : <a href="https://bugs.openjdk.java.net/browse/JDK-8224247">
https://bugs.openjdk.java.net/browse/JDK-8224247</a><o:p></o:p></p>
<p class="MsoNormal">Webrev : <a href="http://cr.openjdk.java.net/~kkharbas/8224247/webrev.00">
http://cr.openjdk.java.net/~kkharbas/8224247/webrev.00</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Changeset 54678 for <a href="https://bugs.openjdk.java.net/browse/JDK-8198505">
https://bugs.openjdk.java.net/browse/JDK-8198505</a> replaced the two methods in CollectorPolicy - max_heap_byte_size() and heap_reserved_size_bytes(), with a single method heap_reserved_size_bytes() in [g1/parallel]Arguments.
<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The second method was introduced in <a href="https://bugs.openjdk.java.net/browse/JDK-8202286">
https://bugs.openjdk.java.net/browse/JDK-8202286</a> to differentiate between the size of reserved memory (heap_reserved_size_bytes(), which might be 2x of MaxHeapSize) and the max size heap can grow (heap_reserved_size_bytes(), which is always MaxHeapSize).
When 'AllocateOldGenAt' flag is used, during heap initialization we need the first size and later on the second size. Adding the second method back fixes the issue.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">The fix is just adding a new method and using it during initialization of G1 and PS heap, but the existing method's name is more appropriate for the new method. So I renamed existing method. This would also avoid confusion about these methods
down the line. <o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Please suggest alternated approach if you see one.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Kishor<o:p></o:p></p>
</div>
</body>
</html>