RFR(XL): 8199712: Flight Recorder

[Dmitry Samersoff]

Erik,

jfrRecorder.cpp:51:10: error: ‘Flag’ does not name a type

   static Flag* const flight_recorder_flag =
Flag::find_flag("FlightRecorder", length);


Should it be JVMFlag ?

-Dmitry


On 04/25/2018 02:06 PM, Erik Gahlin wrote:
> Greetings,
> 
> Could I have a review of 8199712: Flight Recorder
> 
> As mentioned in the preview [1] the tracing backend has been removed.
> Event metadata has been consolidated into a single XML file and event
> classes are now generated by GenerateJfrFiles.java.
> 
> Tests have been run on Linux-x64, Windows-x64 and MaxOSX-x64.
> 
> For details about the feature, see the JEP:
> https://bugs.openjdk.java.net/browse/JDK-8193393
> 
> Webrev:
> http://cr.openjdk.java.net/~egahlin/8199712.0/
> 
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8199712
> 
> [1]
> http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-April/031359.html
> 
> Thanks
> Erik and Markus


-- 
Dmitry Samersoff
http://devnull.samersoff.net
* There will come soft rains ...