RFR: 8208676: Consistent crash when getting event on NetworkPerformanceInterface::NetworkPerformance::network_utilization

[Robin Westberg]

Hi Robbin,

Thanks for reviewing!

Best regards,
Robin

> On 7 Aug 2018, at 17:12, Robbin Ehn <robbin.ehn at oracle.com> wrote:
> 
> On 2018-08-07 13:59, Markus Gronlund wrote:
>> Hi again,
>>  Even better!
> 
> +1, Robbin
> 
>>  Thanks
>> Markus
>>  From: Robin Westberg
>> Sent: den 7 augusti 2018 09:05
>> To: Markus Gronlund <markus.gronlund at oracle.com>
>> Cc: hotspot-jfr-dev at openjdk.java.net
>> Subject: Re: RFR: 8208676: Consistent crash when getting event on NetworkPerformanceInterface::NetworkPerformance::network_utilization
>>  Hi Markus,
>>  Thanks for reviewing!
>>  When reading the getifaddrs documentation I noticed another mistake which I think would be nice to fix at the same time (missing call to freeifaddrs).
>>  New webrev: http://cr.openjdk.java.net/~rwestberg/8208676/webrev.01/
>> Testing: jdk.jfr.event.runtime.* on linux-x64, linux-x64-debug, solaris-sparcv9, solaris-sparcv9-debug
>>  Best regards,
>> Robin
>> On 7 Aug 2018, at 02:00, Markus Gronlund <HYPERLINK "mailto:markus.gronlund at oracle.com <mailto:markus.gronlund at oracle.com>"markus.gronlund at oracle.com <mailto:markus.gronlund at oracle.com>> wrote:
>>  Hi Robin,
>> Looks good, thanks for locating and fixing this so quickly.
>> Markus
>> -----Original Message-----
>> From: Robin Westberg
>> Sent: den 6 augusti 2018 16:05
>> To: HYPERLINK "mailto:hotspot-jfr-dev at openjdk.java.net <mailto:hotspot-jfr-dev at openjdk.java.net>"hotspot-jfr-dev at openjdk.java.net <mailto:hotspot-jfr-dev at openjdk.java.net>
>> Subject: RFR: 8208676: Consistent crash when getting event on NetworkPerformanceInterface::NetworkPerformance::network_utilization
>> Hi all,
>> Please review the following fix for this network utilization related crash that occurs when the system has a network interface without any address configured (linux specific).
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8208676 <https://bugs.openjdk.java.net/browse/JDK-8208676>
>> Webrev: http://cr.openjdk.java.net/~rwestberg/8208676/webrev.00/ <http://cr.openjdk.java.net/~rwestberg/8208676/webrev.00/>
>> Testing: jdk.jfr.event.runtime.* on linux-x64, linux-x64-debug
>> Best regards,
>> Robin