RFR: 8165675: Trace event for thread park has incorrect unit for timeout
Markus Gronlund
markus.gronlund at oracle.com
Tue Dec 11 13:26:13 UTC 2018
Hi Erik,
Looks good, thanks for fixing this.
Markus
-----Original Message-----
From: Erik Gahlin
Sent: den 10 december 2018 21:42
To: hotspot-jfr-dev at openjdk.java.net
Subject: RFR: 8165675: Trace event for thread park has incorrect unit for timeout
Hi,
Could I have a fix of a bug in the ThreadPark event.
The field "timeout" was incorrectly used for both
LockSupport.parkNanos(nanos) and LockSupport.parkUntil(epochMillis). Fix is to use two fields, "timeout" and "until", with different content types. I also improved the unit test so it verifies the contents of the fields. To make it work, I also had to update test framework and the print command of the jfr tool to handle missing values.
For some reason, the test TestEnoughPermission started to fail because it tried to access a class in a restricted package (sun.util.locale.provider). Fix was to not use String.format in the test. Not sure why it happened, but perhaps due to class initialization now happening in a different order.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8165675
Webrev:
http://cr.openjdk.java.net/~egahlin/8165675/
Thanks
Erik
More information about the hotspot-jfr-dev
mailing list