RFR: 8204236: JFR unit test of thread CPU load should be enabled

[Robin Westberg]

Hi Erik,

Thanks for reviewing!

GCC is actually correct here, this is the original error message:
src/hotspot/share/jfr/periodic/jfrThreadCPULoadEvent.cpp:110:6: error: 'static void {anonymous}::JfrThreadCPULoadEvent::send_events()' defined but not used [-Werror=unused-function]
  void JfrThreadCPULoadEvent::send_events() {
       ^~~~~~~~~~~~~~~~~~~~~
 cc1plus: all warnings being treated as errors
Since the function is inside an anonymous namespace, it can only be used inside the current compilation unit. The “proper” fix would be to write additional tests that call these functions as well, I have a few lined up but they are not quite ready yet.

Best regards,
Robin

> On 4 Jun 2018, at 23:54, Erik Gahlin <erik.gahlin at oracle.com> wrote:
> 
> Looks OK, but the gcc thing is weird.
> 
> Erik
> 
>> Hi all,
>> 
>> Please review the following test case fix that enabled the JFR unit tests for the thread CPU load functionality. These tests were disabled during the open source work.
>> 
>> Issue: https://bugs.openjdk.java.net/browse/JDK-8204236 <https://bugs.openjdk.java.net/browse/JDK-8204236>
>> Webrev: http://cr.openjdk.java.net/~rwestberg/8204236/webrev.00/ <http://cr.openjdk.java.net/~rwestberg/8204236/webrev.00/>
>> Testing: hs-tier1
>> 
>> Best regards,
>> Robin
>