RFR: 8203929: Limit amount of data for JFR.dump

[Markus Gronlund]

Hi again Erik,

Thanks a lot for doing this change.  This will very much simplify the usage in getting selective data sets out from JFR.

Thanks also for incorporating some of the suggestions.

Looks good.

Thanks
Markus 

-----Original Message-----
From: Erik Gahlin 
Sent: den 24 juni 2018 22:14
To: Markus Gronlund <markus.gronlund at oracle.com>; hotspot-jfr-dev at openjdk.java.net
Cc: Andrew Gross <andrew.gross at oracle.com>
Subject: Re: RFR: 8203929: Limit amount of data for JFR.dump

Hi Markus.

Here is an updated webrev.

http://cr.openjdk.java.net/~egahlin/8203929.2/

Some of the issues could be handled as RFEs or bug fixes. See private e-mail. I also fixed a typo in MBeanUtils.

Thanks
Erik

> Hi Erik,
>
> I am reading through the code and making some annotations. I have attached a description of my first pass of things, thought I send it your way so you have something to start with, more to come.
>
> Do note the informal character of the review file, some sections are mainly clarifications for my own understanding, but I think you can infer from the context what are questions and suggestions.
>
> Thanks
> Markus
>
> -----Original Message-----
> From: Erik Gahlin
> Sent: den 21 juni 2018 18:16
> To: hotspot-jfr-dev at openjdk.java.net; Andrew Gross 
> <andrew.gross at oracle.com>
> Subject: RFR: 8203929: Limit amount of data for JFR.dump
>
> Hi,
>
> Could I have a a review of an enhancement that will simplify the usage of JFR.dump and make it possible to copy parts of a recording to a file.  For more information, see the CSR:
>
> https://bugs.openjdk.java.net/browse/JDK-8203930
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8203929
>
> Webrev:
> http://cr.openjdk.java.net/~egahlin/8203929/
>
> Testing:
> Tests in test/jdk/jdk/jfr
>
> Thanks
> Erik