RFR: 8003209: JFR events for network utilization

Erik Gahlin erik.gahlin at oracle.com
Wed Jun 27 14:09:10 UTC 2018


Looks good.

Erik

> Hi yet one more time,
>
> Markus found another optimization that allows us to store timestamps once instead of per interface, which should save a bit of space.
>
> Incremental: http://cr.openjdk.java.net/~rwestberg/8003209/webrev.02-03/ <http://cr.openjdk.java.net/~rwestberg/8003209/webrev.02-03/>
> Full: http://cr.openjdk.java.net/~rwestberg/8003209/webrev.03/ <http://cr.openjdk.java.net/~rwestberg/8003209/webrev.03/>
>
> Best regards,
> Robin
>
>> On 26 Jun 2018, at 21:14, Robin Westberg <robin.westberg at oracle.com> wrote:
>>
>> Hi once again,
>>
>> After some additional off-list feedback from Markus I’ve also added a stub implementation for aix (that hopefully compiles), as well as cleaned up the headers included in the unit test.
>>
>> Incremental: http://cr.openjdk.java.net/~rwestberg/8003209/webrev.01-02/ <http://cr.openjdk.java.net/~rwestberg/8003209/webrev.01-02/>
>> Full: http://cr.openjdk.java.net/~rwestberg/8003209/webrev.02/ <http://cr.openjdk.java.net/~rwestberg/8003209/webrev.02/>
>>
>> Best regards,
>> Robin
>>
>>> On 26 Jun 2018, at 15:01, Robin Westberg <robin.westberg at oracle.com> wrote:
>>>
>>> Hi again,
>>>
>>> Markus kindly provided some off-list feedback with a patch to make the serialization of interfaces names more efficient. I’ve incorporated those changes, as well as adapted the unit test and corrected a few copyright years.
>>>
>>> Incremental: http://cr.openjdk.java.net/~rwestberg/8003209/webrev.00-01/ <http://cr.openjdk.java.net/~rwestberg/8003209/webrev.00-01/>
>>> Full: http://cr.openjdk.java.net/~rwestberg/8003209/webrev.01/ <http://cr.openjdk.java.net/~rwestberg/8003209/webrev.01/>
>>>
>>> Best regards,
>>> Robin
>>>
>>>> On 25 Jun 2018, at 21:04, Robin Westberg <robin.westberg at oracle.com> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> Please review the following change with adds a JFR event for tracking network utilization on the network interface level.
>>>>
>>>> Issue: https://bugs.openjdk.java.net/browse/JDK-8003209 <https://bugs.openjdk.java.net/browse/JDK-8003209>
>>>> Webrev: http://cr.openjdk.java.net/~rwestberg/8003209/webrev.00/ <http://cr.openjdk.java.net/~rwestberg/8003209/webrev.00/>
>>>> Testing: test/jdk/jdk/jfr/*
>>>>
>>>> Many thanks to Erik Gahlin and Markus Grönlund who have looked at earlier versions of this change and suggested valuable improvements.
>>>>
>>>> Best regards,
>>>> Robin



More information about the hotspot-jfr-dev mailing list