RFR: 8137164: Include PID in the JFR jcmd hint

[Thomas Stüfe]

Hi Erik,

this looks fine to me.

Since you are changing the output, could we change filename=FILEPATH
to filename=<FILEPATH> or filename=<filepath>, which seems to be the
default for "insert name here"?

Side note, I was looking at this code closely for the first time and I
am surprised how much parsing etc is done on the client side (the
jcmd) - I always thought the principle was to leave jcmd dumb and thus
compatible and let the hotspot itself do all the work? Sorry if the
question is stupid, I do not know much about JFR.

Thanks, Thomas


On Wed, Jun 27, 2018 at 10:09 PM, Erik Gahlin <erik.gahlin at oracle.com> wrote:
> Hi,
>
> Could I have review of the following fix that adds the PID to the output
> when starting a JFR recording.
>
> Webrev:
> http://cr.openjdk.java.net/~egahlin/8137164/
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8137164
>
> Testing:
> test/jdk/jdk/jfr/*
>
> Thanks
> Erik