RFR(XL): 8199712: Flight Recorder

[Erik Gahlin]

Hi Misha,

Thanks for the review. I will fix 1, 2, and 3.

Erik

> Hi Erik,
>
> My review is based on: http://cr.openjdk.java.net/~egahlin/8199712.0/
> I looked at the test portion only.
> Overall looks good, however I have some comments:
>
>   1. A number of JFC files still have "internal copyright header"
>      E.g.: open/test/jdk/jdk/jfr/event/gc/collection/gc-testsettings.jfc
>      <!--
>        * Copyright (c) 2016, Oracle and/or its affiliates. All rights 
> reserved.
>        * ORACLE PROPRIETARY/CONFIDENTIAL. Use is subject to license 
> terms.
>      -->
>      More .jfc files under open/test/jdk/jdk/jfr/ have same issue, or 
> no copyright header at all:
>          ./event/gc/collection/gc-testsettings.jfc
>          ./event/gc/detailed/promotionfailed-testsettings.jfc
>          ./event/gc/detailed/evacuationfailed-testsettings.jfc
> ./event/gc/detailed/concurrentmodefailure-testsettings.jfc
>          ./api/recording/settings/settings.jfc
>          ./jcmd/jcmd-testsettings.2.jfc
>          ./jcmd/jcmd-testsettings.jfc
>          ./jcmd/jcmd-testsettings3.jfc
>
>
>   2. The following files are missing copyright statement:
>       /open/test/jdk/jdk/jfr/event/io/MakeJAR.sh
>
>   3. Please update the copyright year:
>      test/lib/jdk/test/lib/thread/TestThread.java
>      test/lib/jdk/test/lib/thread/XRun.java
>
>
> The rest of test related files look good to me,
> Misha
>
>
> On 05/01/2018 04:37 PM, Vladimir Kozlov wrote:
>> Hi Erik,
>>
>> I am working on 8184349 and adding  & !vm.graal.enabled to @requires 
>> for tests which use CMS. Mostly they are JFR tests which are in this 
>> review list. And I found some test have incorrect commands (merged 2 
>> lines together):
>>
>>  * @test @requires vm.gc == "null" | vm.gc == "Serial"
>>
>> I see that you fixed some. But there few left:
>>
>> test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithDefNew.java 
>>
>> test/jdk/jdk/jfr/event/gc/detailed/TestStressAllocationGCEventsWithG1.java 
>>
>> test/jdk/jdk/jfr/event/gc/detailed/TestStressBigAllocationGCEventsWithParallel.java 
>>
>>
>> Thanks,
>> Vladimir
>>
>> On 4/25/18 4:06 AM, Erik Gahlin wrote:
>>> Greetings,
>>>
>>> Could I have a review of 8199712: Flight Recorder
>>>
>>> As mentioned in the preview [1] the tracing backend has been 
>>> removed. Event metadata has been consolidated into a single XML file 
>>> and event classes are now generated by GenerateJfrFiles.java.
>>>
>>> Tests have been run on Linux-x64, Windows-x64 and MaxOSX-x64.
>>>
>>> For details about the feature, see the JEP:
>>> https://bugs.openjdk.java.net/browse/JDK-8193393
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~egahlin/8199712.0/
>>>
>>> Bug:
>>> https://bugs.openjdk.java.net/browse/JDK-8199712
>>>
>>> [1] 
>>> http://mail.openjdk.java.net/pipermail/hotspot-dev/2018-April/031359.html
>>>
>>> Thanks
>>> Erik and Markus
>