RFR (S): 8195817: JFR.stop should require name of recording

Markus Gronlund markus.gronlund at oracle.com
Thu May 17 20:45:37 UTC 2018


Looks good.

Markus

-----Original Message-----
From: Erik Gahlin 
Sent: den 17 maj 2018 20:52
To: hotspot-jfr-dev at openjdk.java.net
Subject: RFR (S): 8195817: JFR.stop should require name of recording

Hi,

Could I please have a review of this fix.

Problem occurs if a user runs the following command:

 > jcmd <pid> JFR.stop

without specifying which recording to stop. The jcmd fails, but the output is "command executed successfully". Fix is to make the name parameter mandatory.

Bug:
https://bugs.openjdk.java.net/browse/JDK-8195817

Webrev:
  http://cr.openjdk.java.net/~egahlin/8195817.1/

Testing:
Tests in test/jdk/jdk/jfr

Thanks
Erik


More information about the hotspot-jfr-dev mailing list